From 60bc9589b3fb94d2b55086c7ff50f38a4b97bd14 Mon Sep 17 00:00:00 2001 From: Diego Rey Mendez Date: Wed, 19 Jun 2019 16:22:58 -0300 Subject: [PATCH] Documents some critical stats we're tracking. --- WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift | 2 ++ WordPressAuthenticator/Signin/LoginPrologueViewController.swift | 2 ++ WordPressAuthenticator/Signup/SignupGoogleViewController.swift | 2 ++ 3 files changed, 6 insertions(+) diff --git a/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift b/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift index 59b5f27f0..c681fc877 100644 --- a/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift +++ b/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift @@ -33,6 +33,8 @@ class NUXLinkAuthViewController: LoginViewController { if let linkSource = loginFields.meta.emailMagicLinkSource { switch linkSource { case .signup: + // This stat is part of a funnel that provides critical information. Before + // making ANY modification to this stat please refer to: p4qSXL-35X-p2 WordPressAuthenticator.track(.createdAccount, properties: ["source": "email"]) WordPressAuthenticator.track(.signupMagicLinkSucceeded) case .login: diff --git a/WordPressAuthenticator/Signin/LoginPrologueViewController.swift b/WordPressAuthenticator/Signin/LoginPrologueViewController.swift index 9576b2c0a..2ab4d8cd0 100644 --- a/WordPressAuthenticator/Signin/LoginPrologueViewController.swift +++ b/WordPressAuthenticator/Signin/LoginPrologueViewController.swift @@ -85,6 +85,8 @@ class LoginPrologueViewController: LoginViewController { } private func signupTapped() { + // This stat is part of a funnel that provides critical information. Before + // making ANY modification to this stat please refer to: p4qSXL-35X-p2 WordPressAuthenticator.track(.signupButtonTapped) performSegue(withIdentifier: NUXViewController.SegueIdentifier.showSignupMethod.rawValue, sender: self) } diff --git a/WordPressAuthenticator/Signup/SignupGoogleViewController.swift b/WordPressAuthenticator/Signup/SignupGoogleViewController.swift index d41242ee4..43a4701ea 100644 --- a/WordPressAuthenticator/Signup/SignupGoogleViewController.swift +++ b/WordPressAuthenticator/Signup/SignupGoogleViewController.swift @@ -130,6 +130,8 @@ private extension SignupGoogleViewController { /// Social Signup Successful: Analytics + Pushing the Signup Epilogue. /// func socialSignupWasSuccessful(with credentials: AuthenticatorCredentials) { + // This stat is part of a funnel that provides critical information. Before + // making ANY modification to this stat please refer to: p4qSXL-35X-p2 WordPressAuthenticator.track(.createdAccount, properties: ["source": "google"]) WordPressAuthenticator.track(.signupSocialSuccess)