New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log In: show button view with login options. #111
Conversation
…In flow is displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small comment, otherwise
Also, of note: the "Or login using your site address" text appears much smaller on iOS 13 – we'll want to fix that somehow.
let googleTitle = NSLocalizedString("Continue with Google", comment: "Button title. Tapping begins log in using Google.") | ||
|
||
buttonViewController.setupTopButton(title: wordpressTitle, isPrimary: false, accessibilityIdentifier: "Log in with Email Button") { [weak self] in | ||
self?.dismiss(animated: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be tracking a tap on this button too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't think to make a note. I'm keeping a list of new tracks that are needed. I"ll add them a bit later.
Gotcha. Thanks for that. |
Site address font fixed in #115. |
This adds a new Log In flow. Namely, if
showNewLoginFlow
istrue
, when Log In is selected a button view now appears with available options.This can be tested with WPiOS PR wordpress-mobile/WordPress-iOS#12305.