This repository was archived by the owner on Feb 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Remove segue .showLinkMailView
#217
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…ve-showLinkMailView" This reverts commit b9c020a.
1 task
ScoutHarris
approved these changes
Mar 23, 2020
Contributor
ScoutHarris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with wordpress-mobile/WordPress-iOS#13704.
pmusolino
approved these changes
Mar 24, 2020
Contributor
pmusolino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on WCiOS ✅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Ref. #182
This PR removes all references to the segue
.showLinkMailViewand programmatically navigates the user to theNUXLinkMailViewController. There are 3 areas where the segues have been removed:To Test - WPiOS
rake dependenciesand ensure there are no errorsTo Test - WCiOS
rake dependencies.showLinkMailViewsegue and navigate programmatically woocommerce/woocommerce-ios#2023