Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Mar 23, 2020

Fixes #211
Ref. #182

This PR removes all references to the segue .showLinkMailView and programmatically navigates the user to the NUXLinkMailViewController . There are 3 areas where the segues have been removed:

  1. WPiOS sign up
  2. WPiOS sign in
  3. WCiOS sign in

To Test - WPiOS

  1. Check out this branch
  2. rake dependencies and ensure there are no errors
  3. Build and run (there should be no errors)
  4. Visit the WPiOS PR to run the changes: Remove the .showLinkMailView segue and replace with programmatic nav WordPress-iOS#13704

To Test - WCiOS

  1. Check out this branch
  2. rake dependencies
  3. Build and run (there should be no errors)
  4. Visit the WCiOS PR to run the changes: [Auth] Remove the .showLinkMailView segue and navigate programmatically woocommerce/woocommerce-ios#2023

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on WCiOS ✅

@mindgraffiti mindgraffiti merged commit 4caf35f into develop Mar 24, 2020
@mindgraffiti mindgraffiti deleted the issue/211-remove-showLinkMailView branch March 24, 2020 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UL&S: remove .showLinkMailView

4 participants