From 4f80cac63b5dd7ec7ab513ef1912b60d85b6d595 Mon Sep 17 00:00:00 2001 From: Diego Rey Mendez Date: Tue, 22 Dec 2020 15:04:29 -0300 Subject: [PATCH 1/2] Removes all calls to SafariCredentialsService.updateSafariCredentialsIfNeeded(with:) --- .../NUX/NUXLinkAuthViewController.swift | 4 ---- .../Signin/LoginSelfHostedViewController.swift | 7 ------- .../Signin/LoginUsernamePasswordViewController.swift | 8 -------- WordPressAuthenticator/Signin/LoginViewController.swift | 8 -------- .../Site Address/SiteCredentialsViewController.swift | 5 ----- 5 files changed, 32 deletions(-) diff --git a/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift b/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift index 93794e88e..f349d195a 100644 --- a/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift +++ b/WordPressAuthenticator/NUX/NUXLinkAuthViewController.swift @@ -52,8 +52,4 @@ class NUXLinkAuthViewController: LoginViewController { override func configureStatusLabel(_ message: String) { statusLabel?.text = message } - - override func updateSafariCredentialsIfNeeded() { - // Noop - } } diff --git a/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift b/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift index 3195a2d7f..7798de651 100644 --- a/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift +++ b/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift @@ -226,13 +226,6 @@ class LoginSelfHostedViewController: LoginViewController, NUXKeyboardResponder { // MARK: - Instance Methods - /// Noop. Required by the SigninWPComSyncHandler protocol but the self-hosted - /// controller's implementation does not use safari saved credentials. - /// - override func updateSafariCredentialsIfNeeded() { - } - - /// Validates what is entered in the various form fields and, if valid, /// proceeds with the submit action. /// diff --git a/WordPressAuthenticator/Signin/LoginUsernamePasswordViewController.swift b/WordPressAuthenticator/Signin/LoginUsernamePasswordViewController.swift index 4aeddc977..e48a11647 100644 --- a/WordPressAuthenticator/Signin/LoginUsernamePasswordViewController.swift +++ b/WordPressAuthenticator/Signin/LoginUsernamePasswordViewController.swift @@ -206,14 +206,6 @@ class LoginUsernamePasswordViewController: LoginViewController, NUXKeyboardRespo // MARK: - Instance Methods - - /// Noop. Required by the SigninWPComSyncHandler protocol but the self-hosted - /// controller's implementation does not use safari saved credentials. - /// - override func updateSafariCredentialsIfNeeded() { - } - - /// Validates what is entered in the various form fields and, if valid, /// proceeds with the submit action. /// diff --git a/WordPressAuthenticator/Signin/LoginViewController.swift b/WordPressAuthenticator/Signin/LoginViewController.swift index 96aa56378..db72298e1 100644 --- a/WordPressAuthenticator/Signin/LoginViewController.swift +++ b/WordPressAuthenticator/Signin/LoginViewController.swift @@ -220,12 +220,6 @@ open class LoginViewController: NUXViewController, LoginFacadeDelegate { presentUnified2FA() } - - // Update safari stored credentials. Call after a successful sign in. - /// - func updateSafariCredentialsIfNeeded() { - SafariCredentialsService.updateSafariCredentialsIfNeeded(with: loginFields) - } private enum LocalizedText { static let loginError = NSLocalizedString("Whoops, something went wrong and we couldn't log you in. Please try again!", comment: "An error message shown when a wpcom user provides the wrong password.") @@ -261,8 +255,6 @@ extension LoginViewController { /// Signals the Main App to synchronize the specified WordPress.com account. /// private func syncWPCom(credentials: AuthenticatorCredentials, completion: (() -> ())? = nil) { - SafariCredentialsService.updateSafariCredentialsIfNeeded(with: loginFields) - configureStatusLabel(LocalizedText.gettingAccountInfo) authenticationDelegate.sync(credentials: credentials) { [weak self] in diff --git a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift index c9f6bf9f6..2e08a533f 100644 --- a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift +++ b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift @@ -150,11 +150,6 @@ final class SiteCredentialsViewController: LoginViewController { } } - /// No-op. Required by the SigninWPComSyncHandler protocol but the self-hosted - /// controller's implementation does not use safari saved credentials. - /// - override func updateSafariCredentialsIfNeeded() {} - /// No-op. Required by LoginFacade. func displayLoginMessage(_ message: String) {} } From b9540fee2dcc01e4705022185fcc27d96f65977f Mon Sep 17 00:00:00 2001 From: Diego Rey Mendez Date: Tue, 22 Dec 2020 20:15:13 -0300 Subject: [PATCH 2/2] Increases the podspec version. --- WordPressAuthenticator.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator.podspec b/WordPressAuthenticator.podspec index 8c6572ae2..09a6ede30 100644 --- a/WordPressAuthenticator.podspec +++ b/WordPressAuthenticator.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "WordPressAuthenticator" - s.version = "1.33.0-beta.1" + s.version = "1.33.0-beta.2" s.summary = "WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps." s.description = <<-DESC