From c6260840860c571de1303f6dd05956b408b94fe8 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:23:29 -0600 Subject: [PATCH 1/9] Add Ruby tooling --- Gemfile | 4 +- Gemfile.lock | 223 ++++++++++++++++++++++++++++++++++++++++++++++----- 2 files changed, 206 insertions(+), 21 deletions(-) diff --git a/Gemfile b/Gemfile index 906a994cf..fe721e47a 100644 --- a/Gemfile +++ b/Gemfile @@ -1,4 +1,6 @@ source 'https://rubygems.org' -gem 'cocoapods', '~> 1.10.0' +gem 'cocoapods', '~> 1.10' +gem 'cocoapods-check', '~> 1.1' +gem 'fastlane', '~> 2.189' gem 'rubocop', '~> 1.18' diff --git a/Gemfile.lock b/Gemfile.lock index 5eb96ec4d..daca07721 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,23 +2,41 @@ GEM remote: https://rubygems.org/ specs: CFPropertyList (3.0.3) - activesupport (5.2.4.4) + activesupport (5.2.6) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) tzinfo (~> 1.1) - addressable (2.7.0) + addressable (2.8.0) public_suffix (>= 2.0.2, < 5.0) algoliasearch (1.27.5) httpclient (~> 2.8, >= 2.8.3) json (>= 1.5.1) + artifactory (3.0.15) ast (2.4.2) atomos (0.1.3) + aws-eventstream (1.1.1) + aws-partitions (1.489.0) + aws-sdk-core (3.119.1) + aws-eventstream (~> 1, >= 1.0.2) + aws-partitions (~> 1, >= 1.239.0) + aws-sigv4 (~> 1.1) + jmespath (~> 1.0) + aws-sdk-kms (1.46.0) + aws-sdk-core (~> 3, >= 3.119.0) + aws-sigv4 (~> 1.1) + aws-sdk-s3 (1.99.0) + aws-sdk-core (~> 3, >= 3.119.0) + aws-sdk-kms (~> 1) + aws-sigv4 (~> 1.1) + aws-sigv4 (1.2.4) + aws-eventstream (~> 1, >= 1.0.2) + babosa (1.0.4) claide (1.0.3) - cocoapods (1.10.0) + cocoapods (1.10.2) addressable (~> 2.6) claide (>= 1.0.2, < 2.0) - cocoapods-core (= 1.10.0) + cocoapods-core (= 1.10.2) cocoapods-deintegrate (>= 1.0.3, < 2.0) cocoapods-downloader (>= 1.4.0, < 2.0) cocoapods-plugins (>= 1.0.0, < 2.0) @@ -33,7 +51,9 @@ GEM nap (~> 1.0) ruby-macho (~> 1.4) xcodeproj (>= 1.19.0, < 2.0) - cocoapods-core (1.10.0) + cocoapods-check (1.1.0) + cocoapods (~> 1.0) + cocoapods-core (1.10.2) activesupport (> 5.0, < 6) addressable (~> 2.6) algoliasearch (~> 1.0) @@ -43,65 +63,226 @@ GEM netrc (~> 0.11) public_suffix typhoeus (~> 1.0) - cocoapods-deintegrate (1.0.4) + cocoapods-deintegrate (1.0.5) cocoapods-downloader (1.4.0) cocoapods-plugins (1.0.0) nap - cocoapods-search (1.0.0) + cocoapods-search (1.0.1) cocoapods-trunk (1.5.0) nap (>= 0.8, < 2.0) netrc (~> 0.11) cocoapods-try (1.2.0) + colored (1.2) colored2 (3.1.2) - concurrent-ruby (1.1.7) + commander (4.6.0) + highline (~> 2.0.0) + concurrent-ruby (1.1.9) + declarative (0.0.20) + digest-crc (0.6.4) + rake (>= 12.0.0, < 14.0.0) + domain_name (0.5.20190701) + unf (>= 0.0.5, < 1.0.0) + dotenv (2.7.6) + emoji_regex (3.2.2) escape (0.0.4) - ethon (0.12.0) - ffi (>= 1.3.0) - ffi (1.13.1) + ethon (0.14.0) + ffi (>= 1.15.0) + excon (0.85.0) + faraday (1.7.0) + faraday-em_http (~> 1.0) + faraday-em_synchrony (~> 1.0) + faraday-excon (~> 1.1) + faraday-httpclient (~> 1.0.1) + faraday-net_http (~> 1.0) + faraday-net_http_persistent (~> 1.1) + faraday-patron (~> 1.0) + faraday-rack (~> 1.0) + multipart-post (>= 1.2, < 3) + ruby2_keywords (>= 0.0.4) + faraday-cookie_jar (0.0.7) + faraday (>= 0.8.0) + http-cookie (~> 1.0.0) + faraday-em_http (1.0.0) + faraday-em_synchrony (1.0.0) + faraday-excon (1.1.0) + faraday-httpclient (1.0.1) + faraday-net_http (1.0.1) + faraday-net_http_persistent (1.2.0) + faraday-patron (1.0.0) + faraday-rack (1.0.0) + faraday_middleware (1.1.0) + faraday (~> 1.0) + fastimage (2.2.5) + fastlane (2.191.0) + CFPropertyList (>= 2.3, < 4.0.0) + addressable (>= 2.8, < 3.0.0) + artifactory (~> 3.0) + aws-sdk-s3 (~> 1.0) + babosa (>= 1.0.3, < 2.0.0) + bundler (>= 1.12.0, < 3.0.0) + colored + commander (~> 4.6) + dotenv (>= 2.1.1, < 3.0.0) + emoji_regex (>= 0.1, < 4.0) + excon (>= 0.71.0, < 1.0.0) + faraday (~> 1.0) + faraday-cookie_jar (~> 0.0.6) + faraday_middleware (~> 1.0) + fastimage (>= 2.1.0, < 3.0.0) + gh_inspector (>= 1.1.2, < 2.0.0) + google-apis-androidpublisher_v3 (~> 0.3) + google-apis-playcustomapp_v1 (~> 0.1) + google-cloud-storage (~> 1.31) + highline (~> 2.0) + json (< 3.0.0) + jwt (>= 2.1.0, < 3) + mini_magick (>= 4.9.4, < 5.0.0) + multipart-post (~> 2.0.0) + naturally (~> 2.2) + plist (>= 3.1.0, < 4.0.0) + rubyzip (>= 2.0.0, < 3.0.0) + security (= 0.1.3) + simctl (~> 1.6.3) + terminal-notifier (>= 2.0.0, < 3.0.0) + terminal-table (>= 1.4.5, < 2.0.0) + tty-screen (>= 0.6.3, < 1.0.0) + tty-spinner (>= 0.8.0, < 1.0.0) + word_wrap (~> 1.0.0) + xcodeproj (>= 1.13.0, < 2.0.0) + xcpretty (~> 0.3.0) + xcpretty-travis-formatter (>= 0.0.3) + ffi (1.15.3) fourflusher (2.3.1) fuzzy_match (2.0.4) gh_inspector (1.1.3) + google-apis-androidpublisher_v3 (0.10.0) + google-apis-core (>= 0.4, < 2.a) + google-apis-core (0.4.1) + addressable (~> 2.5, >= 2.5.1) + googleauth (>= 0.16.2, < 2.a) + httpclient (>= 2.8.1, < 3.a) + mini_mime (~> 1.0) + representable (~> 3.0) + retriable (>= 2.0, < 4.a) + rexml + webrick + google-apis-iamcredentials_v1 (0.6.0) + google-apis-core (>= 0.4, < 2.a) + google-apis-playcustomapp_v1 (0.5.0) + google-apis-core (>= 0.4, < 2.a) + google-apis-storage_v1 (0.6.0) + google-apis-core (>= 0.4, < 2.a) + google-cloud-core (1.6.0) + google-cloud-env (~> 1.0) + google-cloud-errors (~> 1.0) + google-cloud-env (1.5.0) + faraday (>= 0.17.3, < 2.0) + google-cloud-errors (1.1.0) + google-cloud-storage (1.34.1) + addressable (~> 2.5) + digest-crc (~> 0.4) + google-apis-iamcredentials_v1 (~> 0.1) + google-apis-storage_v1 (~> 0.1) + google-cloud-core (~> 1.6) + googleauth (>= 0.16.2, < 2.a) + mini_mime (~> 1.0) + googleauth (0.17.0) + faraday (>= 0.17.3, < 2.0) + jwt (>= 1.4, < 3.0) + memoist (~> 0.16) + multi_json (~> 1.11) + os (>= 0.9, < 2.0) + signet (~> 0.14) + highline (2.0.3) + http-cookie (1.0.4) + domain_name (~> 0.5) httpclient (2.8.3) - i18n (1.8.5) + i18n (1.8.10) concurrent-ruby (~> 1.0) - json (2.3.1) - minitest (5.14.2) + jmespath (1.4.0) + json (2.5.1) + jwt (2.2.3) + memoist (0.16.2) + mini_magick (4.11.0) + mini_mime (1.1.0) + minitest (5.14.4) molinillo (0.6.6) + multi_json (1.15.0) + multipart-post (2.0.0) nanaimo (0.3.0) nap (1.1.0) + naturally (2.2.1) netrc (0.11.0) + os (1.1.1) parallel (1.20.1) parser (3.0.2.0) ast (~> 2.4.1) + plist (3.6.0) public_suffix (4.0.6) rainbow (3.0.0) + rake (13.0.6) regexp_parser (2.1.1) + representable (3.1.1) + declarative (< 0.1.0) + trailblazer-option (>= 0.1.1, < 0.2.0) + uber (< 0.2.0) + retriable (3.1.2) rexml (3.2.5) - rubocop (1.18.4) + rouge (2.0.7) + rubocop (1.19.1) parallel (~> 1.10) parser (>= 3.0.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml - rubocop-ast (>= 1.8.0, < 2.0) + rubocop-ast (>= 1.9.1, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.8.0) + rubocop-ast (1.10.0) parser (>= 3.0.1.1) ruby-macho (1.4.0) ruby-progressbar (1.11.0) + ruby2_keywords (0.0.5) + rubyzip (2.3.2) + security (0.1.3) + signet (0.15.0) + addressable (~> 2.3) + faraday (>= 0.17.3, < 2.0) + jwt (>= 1.5, < 3.0) + multi_json (~> 1.10) + simctl (1.6.8) + CFPropertyList + naturally + terminal-notifier (2.0.0) + terminal-table (1.6.0) thread_safe (0.3.6) + trailblazer-option (0.1.1) + tty-cursor (0.7.1) + tty-screen (0.8.1) + tty-spinner (0.9.3) + tty-cursor (~> 0.7) typhoeus (1.4.0) ethon (>= 0.9.0) - tzinfo (1.2.8) + tzinfo (1.2.9) thread_safe (~> 0.1) + uber (0.1.0) + unf (0.1.4) + unf_ext + unf_ext (0.0.7.7) unicode-display_width (2.0.0) - xcodeproj (1.19.0) + webrick (1.7.0) + word_wrap (1.0.0) + xcodeproj (1.21.0) CFPropertyList (>= 2.3.3, < 4.0) atomos (~> 0.1.3) claide (>= 1.0.2, < 2.0) colored2 (~> 3.1) nanaimo (~> 0.3.0) + rexml (~> 3.2.4) + xcpretty (0.3.0) + rouge (~> 2.0.7) + xcpretty-travis-formatter (1.0.1) + xcpretty (~> 0.2, >= 0.0.7) PLATFORMS ruby @@ -109,7 +290,9 @@ PLATFORMS x86_64-darwin-20 DEPENDENCIES - cocoapods (~> 1.10.0) + cocoapods (~> 1.10) + cocoapods-check (~> 1.1) + fastlane (~> 2.189) rubocop (~> 1.18) BUNDLED WITH From a7b545a7064f7caa8b4bec8f463d55d02fe9811a Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:23:40 -0600 Subject: [PATCH 2/9] Fix Ruby Version --- .ruby-version | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ruby-version b/.ruby-version index 57cf282eb..2714f5313 100644 --- a/.ruby-version +++ b/.ruby-version @@ -1 +1 @@ -2.6.5 +2.6.4 From 6e97919e0b1a5f9192493e2a35c8b9a6ab543211 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:24:33 -0600 Subject: [PATCH 3/9] Add Rubocop configuration --- .rubocop.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .rubocop.yml diff --git a/.rubocop.yml b/.rubocop.yml new file mode 100644 index 000000000..2dbeb42be --- /dev/null +++ b/.rubocop.yml @@ -0,0 +1,12 @@ +# Opt in to new cops by default +AllCops: + NewCops: enable + +# Allow the Podspec filename to match the project +Naming/FileName: + Exclude: + - 'WordPressAuthenticator.podspec' + +# Override the maximum line length +Layout/LineLength: + Max: 160 From dafb5da7e8a65892d0fe5e6187d594f02f4cf40a Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:25:03 -0600 Subject: [PATCH 4/9] Apply Rubocop fixes Fix additional rubocop complaints Fix Podfile.lock --- .rubocop.yml | 4 ++++ Gemfile | 2 ++ Podfile | 30 +++++++++++++++++------------- Podfile.lock | 4 ++-- WordPressAuthenticator.podspec | 4 +++- 5 files changed, 28 insertions(+), 16 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 2dbeb42be..c9ec8c4c8 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -7,6 +7,10 @@ Naming/FileName: Exclude: - 'WordPressAuthenticator.podspec' +Metrics/BlockLength: + Exclude: + - 'WordPressAuthenticator.podspec' + # Override the maximum line length Layout/LineLength: Max: 160 diff --git a/Gemfile b/Gemfile index fe721e47a..506a3a036 100644 --- a/Gemfile +++ b/Gemfile @@ -1,3 +1,5 @@ +# frozen_string_literal: true + source 'https://rubygems.org' gem 'cocoapods', '~> 1.10' diff --git a/Podfile b/Podfile index 58376cb9a..f36dabd58 100644 --- a/Podfile +++ b/Podfile @@ -1,3 +1,5 @@ +# frozen_string_literal: true + source 'https://cdn.cocoapods.org/' inhibit_all_warnings! @@ -7,6 +9,19 @@ ios_deployment_target = Gem::Version.new('13.0') platform :ios, ios_deployment_target +## Third party libraries +## ===================== +## +def third_party_pods + pod '1PasswordExtension', '1.8.6' + pod 'Alamofire', '4.8' + pod 'CocoaLumberjack', '3.5.2' + pod 'GoogleSignIn', '6.0.1' + pod 'lottie-ios', '3.1.6' + pod 'NSURL+IDN', '0.4' + pod 'SVProgressHUD', '2.2.5' +end + def wordpress_authenticator_pods ## Automattic libraries ## ==================== @@ -16,16 +31,7 @@ def wordpress_authenticator_pods pod 'WordPressKit', '~> 4.18-beta' # Don't change this until we hit 5.0 in WPKit pod 'WordPressShared', '~> 1.12-beta' # Don't change this until we hit 2.0 in WPShared - ## Third party libraries - ## ===================== - ## - pod '1PasswordExtension', '1.8.6' - pod 'Alamofire', '4.8' - pod 'CocoaLumberjack', '3.5.2' - pod 'GoogleSignIn', '6.0.1' - pod 'lottie-ios', '3.1.6' - pod 'NSURL+IDN', '0.4' - pod 'SVProgressHUD', '2.2.5' + third_party_pods end ## WordPress Authenticator @@ -55,9 +61,7 @@ target 'WordPressAuthenticatorTests' do installer.pods_project.targets.each do |target| target.build_configurations.each do |configuration| pod_ios_deployment_target = Gem::Version.new(configuration.build_settings['IPHONEOS_DEPLOYMENT_TARGET']) - if pod_ios_deployment_target <= ios_deployment_target - configuration.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET' - end + configuration.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET' if pod_ios_deployment_target <= ios_deployment_target end end end diff --git a/Podfile.lock b/Podfile.lock index 3af985c02..60c76bf32 100644 --- a/Podfile.lock +++ b/Podfile.lock @@ -105,6 +105,6 @@ SPEC CHECKSUMS: WordPressUI: 1cf47a3b78154faf69caa18569ee7ece1e510fa0 wpxmlrpc: bf55a43a7e710bd2a4fb8c02dfe83b1246f14f13 -PODFILE CHECKSUM: 4daa851e68189bb99fb960a86c2ce1ae4de9cdef +PODFILE CHECKSUM: 7cf50800dab5ef3d524c968936a1fc8242ea023c -COCOAPODS: 1.10.0 +COCOAPODS: 1.10.2 diff --git a/WordPressAuthenticator.podspec b/WordPressAuthenticator.podspec index cd9975f05..118723dcc 100644 --- a/WordPressAuthenticator.podspec +++ b/WordPressAuthenticator.podspec @@ -1,3 +1,5 @@ +# frozen_string_literal: true + Pod::Spec.new do |s| s.name = 'WordPressAuthenticator' s.version = '1.42.0-beta.1' @@ -22,7 +24,7 @@ Pod::Spec.new do |s| s.source_files = 'WordPressAuthenticator/**/*.{h,m,swift}' s.private_header_files = 'WordPressAuthenticator/Private/*.h' s.resource_bundles = { - 'WordPressAuthenticatorResources': [ + WordPressAuthenticatorResources: [ 'WordPressAuthenticator/Resources/Assets.xcassets', 'WordPressAuthenticator/Resources/SupportedEmailClients/*.plist', 'WordPressAuthenticator/Resources/Animations/*.json', From a5000df66260be883c40ba012359b27e308731fc Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:36:00 -0600 Subject: [PATCH 5/9] Add fastlane --- .gitignore | 6 ++++++ fastlane/Fastfile | 15 +++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 fastlane/Fastfile diff --git a/.gitignore b/.gitignore index 5e761662e..468dfaccc 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ # Xcode # +.build build/ *.pbxuser !default.pbxuser @@ -28,3 +29,8 @@ DerivedData Pods/ /vendor + +# Fastlane +fastlane/README.md +fastlane/report.xml +fastlane/test_output diff --git a/fastlane/Fastfile b/fastlane/Fastfile new file mode 100644 index 000000000..da74524a8 --- /dev/null +++ b/fastlane/Fastfile @@ -0,0 +1,15 @@ +# frozen_string_literal: true + +default_platform(:ios) + +platform :ios do + desc 'Builds the project and runs tests' + lane :test do + run_tests( + scheme: 'WordPressAuthenticator', + prelaunch_simulator: true, + buildlog_path: File.join(__dir__, '.build', 'logs'), + derived_data_path: File.join(__dir__, '.build', 'derived-data') + ) + end +end From f397fe60e6e4ec4914019eea79e85f31a416e429 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 14:36:05 -0600 Subject: [PATCH 6/9] Add buildkite config --- .buildkite/pipeline.yml | 51 +++++++++++++++++++++++++++++++++++++++ .buildkite/publish-pod.sh | 17 +++++++++++++ 2 files changed, 68 insertions(+) create mode 100644 .buildkite/pipeline.yml create mode 100644 .buildkite/publish-pod.sh diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml new file mode 100644 index 000000000..e0b0ba7dd --- /dev/null +++ b/.buildkite/pipeline.yml @@ -0,0 +1,51 @@ +# Nodes with values to reuse in the pipeline. +common_params: + plugins: &common_plugins + - &bash_cache automattic/bash-cache#v1.5.0: ~ + env: &common_env + IMAGE_ID: xcode-12.5.1 + +# This is the default pipeline – it will build and test the pod +steps: + ################# + # Build and Test + ################# + - label: "🧪 Build and Test" + key: "test" + command: "build_and_test_pod" + env: *common_env + plugins: *common_plugins + + ################# + # Validate Podspec + ################# + - label: "🔬 Validating Podspec" + key: "validate" + command: "validate_podspec" + env: *common_env + plugins: *common_plugins + + ################# + # Lint + ################# + - label: "🧹 Lint" + key: "lint" + command: "lint_pod" + env: *common_env + plugins: *common_plugins + + ################# + # Publish the Podspec (if we're building a tag) + ################# + - label: "⬆️ Publish Podspec" + key: "publish" + command: .buildkite/publish-pod.sh + env: *common_env + plugins: *common_plugins + depends_on: + - "test" + - "validate" + - "lint" + if: build.tag != null + agents: + queue: "mac" diff --git a/.buildkite/publish-pod.sh b/.buildkite/publish-pod.sh new file mode 100644 index 000000000..35b4cc2f4 --- /dev/null +++ b/.buildkite/publish-pod.sh @@ -0,0 +1,17 @@ +#!/bin/bash -eu + +PODSPEC_PATH="WordPressAuthenticator.podspec" +SPECS_REPO="git@github.com:wordpress-mobile/cocoapods-specs.git" +SLACK_WEBHOOK=$PODS_SLACK_WEBHOOK + +echo "--- :rubygems: Setting up Gems" +install_gems + +echo "--- :cocoapods: Publishing Pod to CocoaPods CDN" +publish_pod $PODSPEC_PATH + +echo "--- :cocoapods: Publishing Pod to WP Specs Repo" +publish_private_pod $PODSPEC_PATH $SPECS_REPO "$SPEC_REPO_PUBLIC_DEPLOY_KEY" + +echo "--- :slack: Notifying Slack" +slack_notify_pod_published $PODSPEC_PATH $SLACK_WEBHOOK From d937cf5b44fb0ffeeb2f23ae057bab5ca102c9b2 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 15:40:46 -0600 Subject: [PATCH 7/9] Remove CircleCI publishing --- .circleci/config.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 257700f52..279e07bc4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -31,18 +31,3 @@ workflows: xcode-version: *xcode-version podspec-path: *podspec bundle-install: true - - ios/publish-podspec: - name: Publish to a8c Spec Repo - xcode-version: *xcode-version - podspec-path: *podspec - spec-repo: https://github.com/wordpress-mobile/cocoapods-specs.git - bundle-install: true - post-to-slack: false - filters: *on-tags-only - - ios/publish-podspec: - name: Publish to Trunk - xcode-version: *xcode-version - podspec-path: *podspec - bundle-install: true - post-to-slack: true - filters: *on-tags-only From bde78d1b7893ccdd05b384a20df7776b7ff3fc64 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:15:21 -0600 Subject: [PATCH 8/9] Move to Xcode 12.5 in CircleCI --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 279e07bc4..e4f8d4598 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ orbs: # YAML anchors for some common/repeated values x-common-params: - - &xcode-version "12.2.0" + - &xcode-version "12.5.0" - &podspec "WordPressAuthenticator.podspec" - &on-tags-only tags: From 6ebd4ee21aa99be26bcbe7cf7c4a40493bf041b9 Mon Sep 17 00:00:00 2001 From: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:25:52 -0600 Subject: [PATCH 9/9] Fix CircleCI issue caused by missing iOS version --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index e4f8d4598..b9f2a14dc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -23,7 +23,7 @@ workflows: workspace: WordPressAuthenticator.xcworkspace scheme: WordPressAuthenticator device: iPhone 11 - ios-version: "14.2" + ios-version: "14.5" bundle-install: true pod-install: true - ios/validate-podspec: