From e86870a3553f95ab75de57a20702ea5d9b709acf Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 14:35:24 +0530 Subject: [PATCH 1/6] Clean up textfield cell's style in prepareForReuse. --- .../Reusable Views/TextFieldTableViewCell.swift | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/WordPressAuthenticator/Unified Auth/View Related/Reusable Views/TextFieldTableViewCell.swift b/WordPressAuthenticator/Unified Auth/View Related/Reusable Views/TextFieldTableViewCell.swift index c083e5aa4..6a03da34f 100644 --- a/WordPressAuthenticator/Unified Auth/View Related/Reusable Views/TextFieldTableViewCell.swift +++ b/WordPressAuthenticator/Unified Auth/View Related/Reusable Views/TextFieldTableViewCell.swift @@ -56,7 +56,13 @@ final class TextFieldTableViewCell: UITableViewCell { override func prepareForReuse() { super.prepareForReuse() + textField.keyboardType = .default + textField.returnKeyType = .default + setSecureTextEntry(false) + showSecureTextEntryToggle = false textField.rightView = nil + textField.accessibilityLabel = nil + textField.accessibilityIdentifier = nil } } From 1a74b9c28399525d93e5bbadd32a3c189d555093 Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 14:36:20 +0530 Subject: [PATCH 2/6] Configure username from `loginFields` to show username on tableview reload. --- .../Site Address/SiteCredentialsViewController.swift | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift index 922e3a4ed..2351c76cf 100644 --- a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift +++ b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift @@ -280,7 +280,8 @@ private extension SiteCredentialsViewController { /// func configureUsernameTextField(_ cell: TextFieldTableViewCell) { cell.configure(withStyle: .username, - placeholder: WordPressAuthenticator.shared.displayStrings.usernamePlaceholder) + placeholder: WordPressAuthenticator.shared.displayStrings.usernamePlaceholder, + text: loginFields.username) // Save a reference to the textField so it can becomeFirstResponder. usernameField = cell.textField From d73a82943f5c4ab6e05e7627bd9a6a5c9c8f14eb Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 14:36:38 +0530 Subject: [PATCH 3/6] Configure password from `loginFields` to show password on tableview reload. --- .../Site Address/SiteCredentialsViewController.swift | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift index 2351c76cf..df8e2d403 100644 --- a/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift +++ b/WordPressAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift @@ -303,7 +303,8 @@ private extension SiteCredentialsViewController { /// func configurePasswordTextField(_ cell: TextFieldTableViewCell) { cell.configure(withStyle: .password, - placeholder: WordPressAuthenticator.shared.displayStrings.passwordPlaceholder) + placeholder: WordPressAuthenticator.shared.displayStrings.passwordPlaceholder, + text: loginFields.password) passwordField = cell.textField cell.textField.delegate = self cell.onChangeSelectionHandler = { [weak self] textfield in From 4c1f68bfb0d9ceb6d57912f50f8c1f28c994cf50 Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 14:38:10 +0530 Subject: [PATCH 4/6] Bump pod spec version. --- WordPressAuthenticator.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator.podspec b/WordPressAuthenticator.podspec index d858a2ef1..50f3fa958 100644 --- a/WordPressAuthenticator.podspec +++ b/WordPressAuthenticator.podspec @@ -2,7 +2,7 @@ Pod::Spec.new do |s| s.name = 'WordPressAuthenticator' - s.version = '2.2.0-beta.2' + s.version = '2.2.1-beta.1' s.summary = 'WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps.' s.description = <<-DESC From f2f89c928c714977692dffd11c5a81824e8ca8e8 Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 14:59:41 +0530 Subject: [PATCH 5/6] Revert "Bump pod spec version." This reverts commit 4c1f68bfb0d9ceb6d57912f50f8c1f28c994cf50. --- WordPressAuthenticator.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator.podspec b/WordPressAuthenticator.podspec index 50f3fa958..d858a2ef1 100644 --- a/WordPressAuthenticator.podspec +++ b/WordPressAuthenticator.podspec @@ -2,7 +2,7 @@ Pod::Spec.new do |s| s.name = 'WordPressAuthenticator' - s.version = '2.2.1-beta.1' + s.version = '2.2.0-beta.2' s.summary = 'WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps.' s.description = <<-DESC From 440fc376cc6895deb5a10358bb3799573e0a1827 Mon Sep 17 00:00:00 2001 From: Sharma Elanthiraiyan Date: Wed, 10 Aug 2022 15:10:04 +0530 Subject: [PATCH 6/6] Bump pod spec beta version. --- WordPressAuthenticator.podspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator.podspec b/WordPressAuthenticator.podspec index d858a2ef1..9413f316c 100644 --- a/WordPressAuthenticator.podspec +++ b/WordPressAuthenticator.podspec @@ -2,7 +2,7 @@ Pod::Spec.new do |s| s.name = 'WordPressAuthenticator' - s.version = '2.2.0-beta.2' + s.version = '2.2.0-beta.3' s.summary = 'WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps.' s.description = <<-DESC