Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@jklausa
Copy link
Contributor

@jklausa jklausa commented Feb 19, 2019

Description

This is a counterpart to the Insights fetching — handling data that's tied to specific time intervals.

This PR is meant mostly to show how I'm planning to tackle it architecturally — there are only two classes so far — more to come in future PRs tomorrow.

one caveat: the naming in this PR is atrocious. I want to change every single class name I introduce here, but I couldn't come up with anything better on the spot, and I didn't want to bang my head against the wall for few hours just trying to come up with better names. I promise I'll rename it before I'm done with all of the networking.

Testing Details

  • Verify the project builds
  • Verify the tests pass
  • Please check here if your pull request includes additional test coverage.

@jklausa jklausa self-assigned this Feb 19, 2019
@jklausa jklausa requested a review from ScoutHarris February 19, 2019 16:39
@ScoutHarris
Copy link
Contributor

I didn't want to bang my head against the wall for few hours just trying to come up with better names

Because.... no one does that. 😉

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@jklausa jklausa merged commit 0b070a1 into develop Feb 19, 2019
@jklausa jklausa deleted the feature/fetching-time-series-data-pr branch February 19, 2019 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants