Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote block #207

Closed
koke opened this issue Oct 29, 2018 · 3 comments

Comments

@koke
Copy link
Member

commented Oct 29, 2018

Add support for the quote block.

What we're not implementing in the beta:

  • Text alignment
  • Inspector settings: text size and color
  • Quote styles. Not specific to quotes, we might need block transformations first.

@koke koke added this to the Beta milestone Oct 29, 2018

@koke koke added this to Beta in Mobile Gutenberg Oct 29, 2018

@koke

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2018

From @daniloercoli:

I did some research and guess we can tackle this block in a couple of days, even though it could be necessary to make some changes to AztecWrapper. 1 week from start to end to be on the safe side.

Estimating 1 week per platform

@koke koke removed the Needs Estimation label Nov 6, 2018

@etoledom etoledom moved this from Beta to Next Sprint in Mobile Gutenberg Jan 15, 2019

@etoledom etoledom self-assigned this Jan 15, 2019

@etoledom etoledom moved this from Next Sprint to In progress in Mobile Gutenberg Jan 15, 2019

@hypest hypest moved this from In progress to Future in Mobile Gutenberg Jan 17, 2019

@etoledom etoledom removed their assignment Jan 17, 2019

@Tug Tug moved this from Future to More blocks in Mobile Gutenberg Feb 28, 2019

@koke koke moved this from More blocks to 2.0 Features in Mobile Gutenberg Apr 12, 2019

@Tug Tug moved this from 2.0 Features to Sprint #28 in Mobile Gutenberg Apr 18, 2019

@Tug Tug moved this from Sprint #28 to In progress in Mobile Gutenberg Apr 18, 2019

@Tug Tug self-assigned this Apr 18, 2019

@koke koke unassigned Tug May 6, 2019

@koke koke moved this from In progress to 2.0 Features in Mobile Gutenberg May 6, 2019

@SergioEstevao SergioEstevao moved this from 2.0 Features to In progress in Mobile Gutenberg May 30, 2019

@SergioEstevao SergioEstevao moved this from In progress to In review in Mobile Gutenberg May 30, 2019

@SergioEstevao

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

@iamthomasbishop here is a screenshot with the current state of quotes:

Simulator Screen Shot - iPhone Xʀ - 2019-06-03 at 10 31 42

@iamthomasbishop

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

This is looking really close already, great work @SergioEstevao ! I apologize for not having the specs in the Zeplin project earlier – I 100% thought they were already in there! There are a couple of tiny things that jump out at me:

  • There should be a small space between the quote and citation – 16pt

  • The citation font-size should be slightly smaller – 14pt

For visual reference:

image

@SergioEstevao SergioEstevao referenced this issue Jun 4, 2019
0 of 1 task complete

Mobile Gutenberg automation moved this from In review to Done Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.