Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Video block #687
TO DO items to go publicly available:
TODO items next:
Note about video playing differences between platforms
Currently on iOS we have a pull page video play, on Android we have inline.
This is because we have limitations on react-native-video level. Having control buttons(like play, pause etc) in the video block are messing up the layout on iOS, so I had to hide them and add our own play button which opens the video on full page. Once the video opens full page then there's no problem about control buttons. A bit of a technical insight: I think this is the line responsible for it, they are setting the frame (as a workaround for some issue) when controls=true
On the other hand on Android the full page preview just doesn’t work, the method call does nothing. But control buttons do work correctly. The video can play inline.
So now, we have different user experiences in both platforms in terms of video playing. If we want to make this equal in the future we'll need to either solve one of this: