Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
UI for invalid block content #1021
This PR implements
Update release notes:
Already looks really close design-wise, nice work @etoledom! And I figured option 1 would be the easiest, good call.
The design is the same as the inner part of the Unsupported/Placeholder block, but with an added description instead of the placeholder action button. I will drop you the link directly to the component in Zeplin via DM
Looks good @etoledom !
I'm only concerned about the combination of UI + red screen + yellow warnings I'm seeing with this. The UI part is fine and makes sense but, I'm a bit annoyed by the red screen (since we are already handling the error). We've discussed this over chat of course so not going to go deeper into this part. What it's not clear to me is what are the warnings popping up and whether, as a developer, I will need to dive into those to investigate when I see them occuring in the demo app. Here's a screenshot from the demo app with the test content (as described in the PR description):
So, if the warnings there are expected, can we find a way to consolidate with the red-screen too? It's too verbose to have so many different indications of the error (redscreen + yellow message) if they actually stem from the same error.
Hey @hypest - thanks for checking it out!
The error comes from
And the warnings come from:
We could downgrade the error into a warning, getting this result:
We still get multiple warnings, but it's explicit that it's about Block validation.
Alternatively, we can deactivate the red screen for errors. It will still display for Exceptions.
Happy to have any improvement on this one in a separate PR @etoledom , no prob
The yellow warning was something that I think we didn't discuss over chat when we talked about the redscreen, so it took me by surprise... not trying to bring the redscreen conversation up again.