Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link "open in new tab" switch #1030

Merged
merged 6 commits into from May 27, 2019

Conversation

@etoledom
Copy link
Contributor

commented May 24, 2019

This PR updates the gutenberg ref to test WordPress/gutenberg#15812

It fixes the "Open in New Tab" option for links in gutenberg-mobile, where the switch started always off, even a link target was set.

Fixes #1018

link-switch

To test:
Please refer to WordPress/gutenberg#15812 for testing steps.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added the bugfix label May 24, 2019

@etoledom etoledom added this to the v1.6 milestone May 24, 2019

@etoledom etoledom requested a review from mkevins May 24, 2019

@etoledom etoledom self-assigned this May 24, 2019

@mkevins
Copy link
Contributor

left a comment

I tested this on Android and iOS, and this fixes the issue as described.

Good work 🎉!

Once gutenberg reference is updated, and release notes conflicts are resolved: LGTM!

@hypest

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

I will update and merge this PR since Eduardo is AFK.

@hypest hypest merged commit d67ce89 into develop May 27, 2019

6 checks passed

Peril All green. Well done.
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details

@hypest hypest deleted the issue/1018-link-open-new-tab branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.