Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Additional alignment of focus and selection logic with the web's #1076
Gutenberg PR: WordPress/gutenberg#15999
This PR makes changes to the Aztec wrapper (Android) as well as the RN app to bring it closer to the web as far as focus and selection logic goes.
Also, test focus and selection in general, it should work as expected.
Known issue: at least on Android v7.1.2, sometimes a paragraph block will still have the caret blinking inside it even though a different block might be selected. This seems to be an issue with how the accessibility flag is implemented on ReactNative, in combination with the Android OS underneath it. In particular, setting a block to
Update release notes:
Hey @hypest it's offtopic but just curious. Is it possible to do a similar approach with
Hey @hypest, nice work here :)
Here are the issues that I have found and which I can't confirm on develop branch.
1. Red screen
Result: Red screen
2. Keyboard not dismissed
Result: Keyboard is not dismissed
Issues that don't have a clear scenario (and maybe not affected by this PR)
I was able to reproduce the above red screen on the demo app. I cannot reproduce the same on develop. I was able to reproduce it with less steps. Simply moving a rich text block and then selecting it (tap anywhere in the recently moved block) seems to trigger the error. I reproduced this on heading, paragraph, and image caption. If a different block is tapped after moving the block, and then the moved block is tapped, the error does not occur.
Here is the logcat:
I have tested this via demo app and the crash has been fixed.
I agree, this is looking and feeling a lot better after this fix.