Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/697 change color of text and links #1086

Merged
merged 18 commits into from Jun 10, 2019

Conversation

@SergioEstevao
Copy link
Contributor

commented Jun 6, 2019

Fixes #697

Related GB PR: WordPress/gutenberg#16016

Simulator Screen Shot - iPhone Xʀ - 2019-06-06 at 14 40 39

This PR updates the RCTAztecView component to support the setting of base text color and the color for links.

To test:

  • Run the demo app
  • Check that the default body text on text blocks (paragraph/list/quotes) is using the new gray 900 color.
  • Check that links are being draw with the new blue-500 color

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

@daniloercoli or @mkevins I need help to support the link color on Android. It would also be nice to add underlines to links on Android.

@iamthomasbishop
Copy link
Contributor

left a comment

Looks great on the design side! Once we get Android set up, feel free to ping me for review. :shipit:

@etoledom
Copy link
Contributor

left a comment

Looks good on iOS!

On Android the text color is set but the links color are not changing.
(I'm not the best to asses color though, being colorblind)

Maybe we can have this change on the release notes too? 🤔
Since is a user facing change.

Let's 🚢 after Android is ready to go

@etoledom

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Would it be worth it to ship this one for iOS and add a ticket to handle the Android side on a separated PR? 🤔

@iamthomasbishop

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@etoledom I think so, but I’m not sure what the timeline of getting this to work on Android is looking like.

@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@marecar3 do you think you can handle this?

@marecar3

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Hey @SergioEstevao, I am not sure what is the scope of the work regarding Android, let me check and I will be back with some comment. Tnx.

SergioEstevao added some commits Jun 10, 2019

Merge branch 'develop' into issue/697_change_color_of_text_and_links
# Conflicts:
#	gutenberg
#	react-native-aztec/ios/Cartfile
#	react-native-aztec/ios/Cartfile.resolved
Merge pull request #1109 from wordpress-mobile/issue/697_Android-dani…
…lo-hardcode_color_links

Hardcode link text color in Android
@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@etoledom Android part merged in, do you want to give it another look?

Screenshot 2019-06-10 at 16 36 13

@etoledom etoledom self-requested a review Jun 10, 2019

@etoledom
Copy link
Contributor

left a comment

Looking great! 🎉

There is just one small detail on Android:
Screenshot_20190610-192928

The dots... but I guess that is story for another day 😆

Let's :shipit: !

@iamthomasbishop

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@etoledom I noticed that bullet color too but haven't had a chance to submit a new issue. Would you mind creating an issue for this? 🙃

@etoledom

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@iamthomasbishop

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

@etoledom thank you!

@SergioEstevao SergioEstevao merged commit 3994c58 into develop Jun 10, 2019

6 checks passed

Peril All green. Woo!
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.