Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable video block on Android #1150

Conversation

@daniloercoli
Copy link
Contributor

commented Jun 18, 2019

This PR re-enables the Video block on Android.

Companion Gutenberg PR: WordPress/gutenberg#16215

Note: this PR targets the Android X migration PR, since Video block need the Android X migration to be working fine (See: overflow problems and no previews).

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Tug added some commits Jun 18, 2019

Merge pull request #1149 from wordpress-mobile/update/move-block-tool…
…bar-to-gutenberg

Move BlockToolbar to Gutenberg
Merge pull request #1133 from wordpress-mobile/update/move-inline-too…
…lbar-to-block-mobile-toolbar

Port InlineToolbar to Gutenberg as BlockMobileToolbar
@marecar3
Copy link
Contributor

left a comment

LGTM! :)

marecar3 added some commits Jun 18, 2019

@daniloercoli daniloercoli merged commit 12a3546 into issue/android_x_migration Jun 19, 2019

6 checks passed

Peril All green. Good on 'ya.
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details

@daniloercoli daniloercoli deleted the fix/re-enable-video-block-after-android-x-migration branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.