Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping on an empty editor area creates a new paragraph block #1200

Conversation

@marecar3
Copy link
Contributor

commented Jul 5, 2019

This PR introduces tappable empty editor area which creates a new paragraph block.

It's the first iteration of #358 intended for the Beta release.
Next iteration would cover more complex UI: #1020

Following gutenberg PR: WordPress/gutenberg#16439

To test:

  1. Open the Gutenberg Editor
  2. Tap on the empty editor area

Result: New paragraph block should be created

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@marecar3 marecar3 requested review from mchowning and etoledom Jul 5, 2019

@marecar3 marecar3 self-assigned this Jul 5, 2019

@marecar3 marecar3 added this to the Open Beta milestone Jul 5, 2019

@marecar3 marecar3 changed the title Tapping on an empty editor area creates new paragraph block Tapping on an empty editor area creates a new paragraph block Jul 5, 2019

marecar3 added some commits Jul 5, 2019

Merge branch 'develop' into issue/358-tapping-on-an-empty-editor-area…
…-creates-empty-paragraph-block

# Conflicts:
#	gutenberg
@etoledom
Copy link
Contributor

left a comment

Great job! 🎉

Tested via WordPress/gutenberg#16439 (review)

@hypest hypest modified the milestones: Open Beta, 1.10 Jul 8, 2019

@marecar3

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Thanks @etoledom !

@marecar3 marecar3 modified the milestones: 1.10, 1.9 Jul 8, 2019

@marecar3

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Changing this from 1.10 to 1.9 as we can still sneak it.

@marecar3 marecar3 merged commit 544ca0c into develop Jul 8, 2019

6 checks passed

Peril All green. Congrats.
Details
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details

@marecar3 marecar3 deleted the issue/358-tapping-on-an-empty-editor-area-creates-empty-paragraph-block branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.