Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide block if being replaced #1262

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@mchowning
Copy link
Contributor

commented Aug 6, 2019

Fixes #1177 by hiding a block that would be replaced when the add block bottom sheet is presented.

Further description and testing steps are available in the related gutenberg PR.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
Copy link
Contributor

left a comment

Working as expected!
Nice work here! 🎉

The only thing that I would
probably change here is to put some prefix in front of the branch name, e.g. fix/hide_block_if_being_replaced or issue/hide_block_if_being_replaced as it's a good practice here.
But as that change would demand new PR, let's move it with this.

@hypest

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

The only thing that I probably change here is to put some prefix in front of the branch name, e.g. fix/hide_block_if_being_replaced or issue/hide_block_if_being_replaced as it's a good practice here.

Good point. We technically follow the naming guidelines of the main WP apps anyway (see https://github.com/wordpress-mobile/WordPress-Android/wiki/Pull-Request-Guidelines) which point back to https://make.wordpress.org/mobile/handbook/general-guides/git-branching/#feature-branches. In this case, the typical branch name we'd use is: issue/1177-hide-block-if-being-replaced

@mchowning mchowning force-pushed the hide_block_if_being_replaced branch 2 times, most recently from e501ee8 to 91a99be Aug 20, 2019
@mchowning mchowning force-pushed the hide_block_if_being_replaced branch from 91a99be to 6e5e936 Aug 20, 2019
@mchowning mchowning merged commit f6c44c0 into develop Aug 21, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@mchowning mchowning deleted the hide_block_if_being_replaced branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.