Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML mode error on iOS #1305

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@mchowning
Copy link
Contributor

commented Aug 20, 2019

Fixes #1303 . Additional details and testing instructions are in the description of the related gutenberg PR.

Update release notes:

I only observed this red screen error was only visible on dev builds, so there are no user facing changes. Therefore, the release notes have not been updated.

@mchowning mchowning requested review from Tug and etoledom Aug 20, 2019
@mchowning mchowning added this to the 1.12 milestone Aug 20, 2019
@mchowning mchowning added the bugfix label Aug 20, 2019
@mchowning mchowning changed the title Update gutenberg ref Fix HTML mode error on iOS Aug 20, 2019
@mchowning

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

👋 @etoledom . You opened #1303 against the 1.11 milestone. When I checked the most recent internal build for iOS I didn't observe any crash or other problems. If I'm not missing something, what do you think about targeting this fix for 1.12 since the release branches have already been cut? Admittedly, this seems like a pretty safe fix, but if there's no user-facing reason we need to push this fix in right away, seems like we're better off not rushing it.

@etoledom

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

So, first it was my mistake since Tickets should not really have milestones 😁

As far as I understand, our current frozen branch is 1.11, right? This one will go together with WP apps v13.2.
Being that the case, if we don't target our current frozen branch, we will be shipping this crash on the next release cycle.

Let me know if I messed up the numbers :)

@mchowning

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

As far as I understand, our current frozen branch is 1.11, right? This one will go together with WP apps v13.2.

That all sounds right to me.

if we don't target our current frozen branch, we will be shipping this crash on the next release cycle.

My point was that I don't think this is a crash. I believe it's just a red-screen error, which is only shown on dev (and even on dev builds can be dismissed). For example, if I build the release branch and do not have the bundler running, I'm not seeing any issues. I could definitely be missing something though, so let me know.

@mchowning mchowning force-pushed the issue/1303_fix-html-mode-error branch from 1a51a6b to 0466046 Aug 22, 2019
@mchowning mchowning changed the base branch from develop to release/1.11.0 Aug 22, 2019
@mchowning

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

After more investigation, I'm pretty sure this isn't a crash on release builds, but I'm not 100% sure that it might not be a crash on some devices (concerns me that we seem to see some different behavior in our tests), so I'm swayed to your view @etoledom . 😀 Let's include this in v1.11.

I've updated the PRs and target branches appropriately.

Copy link
Contributor

left a comment

@mchowning mchowning force-pushed the issue/1303_fix-html-mode-error branch from 0466046 to 41c945d Aug 23, 2019
@mchowning mchowning force-pushed the issue/1303_fix-html-mode-error branch from 41c945d to 1ed1d94 Aug 23, 2019
@mchowning mchowning merged commit 393f9b2 into release/1.11.0 Aug 23, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@mchowning mchowning deleted the issue/1303_fix-html-mode-error branch Aug 23, 2019
@hypest hypest referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.