Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link target option on Image Block #1394

Merged
merged 8 commits into from Oct 3, 2019

Conversation

@etoledom
Copy link
Contributor

etoledom commented Oct 1, 2019

Resolves part of #1337

This PR add an extra setting to Image Settings bottom sheet to be able to open links on a new tab (Link target).

More info:
Gutenberg side PR: WordPress/gutenberg#17675

link_target

To test:

  • Build and run the mobile example app.
  • On an image block, set a link and turn "Open in a new tab" ON.
  • Close the bottom sheet and open the settings again.
  • Check that the settings were saved and display as before.
  • Press Clear All Settings.
  • Check that all settings are removed.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
etoledom added 3 commits Oct 1, 2019
@etoledom etoledom requested a review from mchowning Oct 1, 2019
@etoledom etoledom self-assigned this Oct 1, 2019
Copy link
Contributor

mchowning left a comment

Tested via gutenberg#17675 and everything is working great on both platforms.

Should we update the release notes though?

@etoledom

This comment has been minimized.

Copy link
Contributor Author

etoledom commented Oct 2, 2019

Should we update the release notes though?

Absolutely! Added on 39bc443

Thanks for the review @mchowning !

@etoledom etoledom requested a review from mchowning Oct 2, 2019
@etoledom etoledom added this to the 1.15 milestone Oct 2, 2019
Copy link
Contributor

mchowning left a comment

:shipit:

@etoledom etoledom merged commit e3d7753 into develop Oct 3, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@etoledom

This comment has been minimized.

Copy link
Contributor Author

etoledom commented Oct 3, 2019

Thank you!

@etoledom etoledom deleted the issue/1337-link-to-open-new-tab branch Oct 3, 2019
@phillipcornwell

This comment has been minimized.

Copy link

phillipcornwell commented Nov 3, 2019

Testing environment:
iPhone 7 Plus
iOS 13.1.3
Chrome 77.0.3865.103
Safari 13
Firefox 20.0
Microsoft Edge 44.9.13
DuckDuckGo Privacy Browser 7.31.1
Opera Touch web browser 2.0.3

Results:
The feature worked well for me in the six browsers I've installed on my phone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.