Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the block title in unsupported blocks #1533

Merged
merged 19 commits into from Nov 8, 2019

Conversation

@hypest
Copy link
Contributor

hypest commented Nov 4, 2019

Fixes #479

Includes the locally available block title in the "Unsupported block" UI for better clarity and context.

Work mostly performed by @illusaen. I'm opening a new set of PRs to land this fast while Wendy is temporarily away.

Gutenberg PR: WordPress/gutenberg#18268

To test:

TBD

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@hypest hypest requested a review from SergioEstevao Nov 4, 2019
hypest added 3 commits Nov 4, 2019
@hypest hypest added this to the 1.17 milestone Nov 5, 2019
Copy link
Contributor

SergioEstevao left a comment

Looking great on light and dark mode!

hypest added 3 commits Nov 7, 2019
@hypest hypest merged commit 05cef95 into develop Nov 8, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@hypest hypest deleted the issue/479-block-title-in-unsupported-block branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.