Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GB reference to support copy of url in clipboard. #1537

Merged
merged 9 commits into from Nov 6, 2019

Conversation

@SergioEstevao
Copy link
Contributor

SergioEstevao commented Nov 4, 2019

Fixes #680

GB PR: WordPress/gutenberg#18279

To test:

  • Start the demo app
  • Switch to Safari and copy a link from the url bar
  • Switch to GB demo app
  • Select a text block
  • Select a bit of text
  • Tap on the link button
  • Check that the URL that you copied from Safari is added to the URL field in the link modal
  • Edit an already existing link and check that the link in the clipboard does not override the one already existing.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@SergioEstevao SergioEstevao added this to the 1.17 milestone Nov 4, 2019
@SergioEstevao SergioEstevao requested review from koke and hypest Nov 4, 2019
Copy link
Contributor

hypest left a comment

Works like a charm, both on Android and iOS!

Let's make sure the checkbox in the PR descriptions are considered and marked before merging these PRs, thanks!

@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

SergioEstevao commented Nov 5, 2019

@hypest PR update with release notes, do you mind give it another look.

@hypest
hypest approved these changes Nov 6, 2019
Copy link
Contributor

hypest left a comment

LGTM!

@hypest hypest merged commit e49f509 into develop Nov 6, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@hypest hypest deleted the issue/680_link_prefill_url_from_clipboard branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.