Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show new block indicator in default appender too #1542

Merged
merged 11 commits into from Nov 6, 2019

Conversation

@hypest
Copy link
Contributor

hypest commented Nov 5, 2019

Fixes #632

Addresses the subcase in #632 where the new-block indicator wasn't shown when the block list was empty and not interacted with yet.

Also, showing the indicator when at the last block of the list.

Gutenberg PR: WordPress/gutenberg#18289

To test:

  1. Locally edit the initial-html.js file to have an empty block list
  2. Run the demo app
  3. Tap on the "+" button to insert a new block
  4. Notice the "ADD BLOCK HERE" indicator right below the title block 馃帀

To test 2:

  1. Locally edit the initial-html.js file to have an empty block list
  2. Run the demo app
  3. Type some text in the "Start writing" prompt
  4. Tap on the "+" button to insert a new block
  5. Notice the "ADD BLOCK HERE" indicator right below the paragraph block 馃帀

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
hypest added 4 commits Nov 5, 2019
@hypest hypest added this to the 1.17 milestone Nov 5, 2019
@hypest hypest requested a review from mchowning Nov 5, 2019
@hypest hypest merged commit 7085502 into develop Nov 6, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@hypest hypest deleted the issue/632-add-new-block-indicator-in-appender-too branch Nov 6, 2019
@jbinda jbinda mentioned this pull request Nov 19, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.