Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & Text alignment options #1546

Merged
merged 5 commits into from Nov 8, 2019

Conversation

@lukewalczak
Copy link
Collaborator

lukewalczak commented Nov 6, 2019

Fixes #1312
Ref to gutenberg: WordPress/gutenberg#18300

To test:

  1. Run the app
  2. Play with Media & Text alignments options using these buttons:

image

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@lukewalczak lukewalczak changed the title Align Media & Text options Media & Text alignment options Nov 6, 2019
@lukewalczak lukewalczak mentioned this pull request Nov 6, 2019
5 of 5 tasks complete
@lukewalczak lukewalczak self-assigned this Nov 6, 2019
lukewalczak added 2 commits Nov 6, 2019
@lukewalczak lukewalczak marked this pull request as ready for review Nov 7, 2019
@pinarol
pinarol approved these changes Nov 8, 2019
Copy link
Contributor

pinarol left a comment

Tested as described in the child PR. Let's revert the initial-html and :shipit:

lukewalczak added 2 commits Nov 8, 2019
…rg-mobile into callstack/rnmobile/alignment-media-text
@lukewalczak lukewalczak merged commit 63c882d into develop Nov 8, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@lukewalczak lukewalczak deleted the callstack/rnmobile/alignment-media-text branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.