Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native fullscreen image preview #1577

Conversation

@cameronvoell
Copy link
Contributor

cameronvoell commented Nov 14, 2019

Fixes #1286

This PR adds a native method call for fullscreen image previews, for now Android only.

Related PRs:

To test:

To test on Android refer to WPAndroid PR: wordpress-mobile/WordPress-Android#10714

*Note this branch is pointing to cameronvoell gutenberg repo until WordPress/gutenberg#18493 is merged. Done c8cee10.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@cameronvoell cameronvoell changed the title Add/mobile fullscreen image preview android media preview activity Add native fullscreen image preview Nov 14, 2019
@cameronvoell cameronvoell marked this pull request as ready for review Nov 14, 2019
… while image is uploading or failed to upload.
@cameronvoell cameronvoell added this to the 1.17 milestone Nov 14, 2019
@hypest
hypest approved these changes Nov 14, 2019
Copy link
Contributor

hypest left a comment

LGTM!

Tested it on WPAndroid (works great!) and WPiOS (not bringing up any fullscreen image preview there, as expected)

I will start updating and merging the PRs.

@hypest hypest removed the DO NOT MERGE label Nov 14, 2019
@hypest hypest merged commit 1c0bfce into release/1.17 Nov 14, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@hypest hypest deleted the add/mobile-fullscreen-image-preview-android-media-preview-activity branch Nov 14, 2019
.gitmodules Outdated
@@ -1,6 +1,6 @@
[submodule "gutenberg"]
path = gutenberg
url = ../../cameronvoell/gutenberg.git
url = ../../WordPress/gutenberg.git

This comment has been minimized.

Copy link
@cameronvoell

cameronvoell Nov 14, 2019

Author Contributor

thanks for updating this!

This comment has been minimized.

Copy link
@hypest

hypest Nov 14, 2019

Contributor

The failing CI jobs helped me remember it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.