Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash which occurs after deleting image or page break block #1582

Conversation

@marecar3
Copy link
Contributor

marecar3 commented Nov 15, 2019

Fixes: wordpress-mobile/WordPress-Android#10491

Gutenberg PR: WordPress/gutenberg#18539
WPAndroid PR: wordpress-mobile/WordPress-Android#10805

To test:
Steps to repro - Case A

  • Create a new post
  • Click on the empty paragraph block
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Page break block should be deleted as expected

Steps to repro - Case B

  • Create a new post
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • This time the block is removed without a crash_
  • Add a Page break block
  • Click on the "bin" on the Page break block
  • Page break block should be deleted as expected

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@marecar3 marecar3 added the bugfix label Nov 15, 2019
@marecar3 marecar3 added this to the 1.17 milestone Nov 15, 2019
@marecar3 marecar3 self-assigned this Nov 15, 2019
@marecar3 marecar3 changed the base branch from develop to release/1.17 Nov 15, 2019
@marecar3 marecar3 mentioned this pull request Nov 15, 2019
1 of 1 task complete
@marecar3 marecar3 changed the title Hotfix/crash which occurs after deleting image or page break block Fix crash which occurs after deleting image or page break block Nov 15, 2019
@hypest

This comment has been minimized.

Copy link
Contributor

hypest commented Nov 15, 2019

Works for me and fixes the block deletion issue!

Copy link
Contributor

SergioEstevao left a comment

Tested on iOS and Android and all working great!

marecar3 added 2 commits Nov 15, 2019
@marecar3 marecar3 merged commit 77ffeea into release/1.17 Nov 15, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@marecar3 marecar3 deleted the hotfix/crash-which-occurs-after-deleting-Image-or-Page-break-block branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.