Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables native image fullscreen preview on iOS #1597

Merged
merged 7 commits into from Nov 21, 2019

Conversation

@cameronvoell
Copy link
Contributor

cameronvoell commented Nov 20, 2019

Fixes #1286

WordPress-iOS PR: wordpress-mobile/WordPress-iOS#12979
gutenberg PR: WordPress/gutenberg#18618

Description

This change enables a call to native fullscreen image previews on iOS from the mobile image block. It also fixes some minor UX issues around not highlighting the image while caption is selected and not launching fullscreen image on tap when caption is selected (See #1286 (comment) ).

Testing

  1. Navigate to edit a post in the Block Editor.
  2. Add an image block and upload an image from any source.
  3. Click on the image once to show a blue border highlighted state.
  4. Click the image while the image block is selected and verify the preview image screen is shown.
  5. Update release notes:

ios-fullscreen-video

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
…w for for an image from a URL on iOS.
@cameronvoell cameronvoell marked this pull request as ready for review Nov 20, 2019
Copy link
Contributor

etoledom left a comment

Looks good and works great 🎉

I left a small comment to be fixed before merging 👍

@cameronvoell cameronvoell merged commit aa2bff4 into develop Nov 21, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@hypest hypest deleted the add/image-fullscreen-preview-ios-native branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.