Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement video block settings #1601

Merged
merged 8 commits into from Nov 28, 2019
Merged

Conversation

@SergioEstevao
Copy link
Contributor

SergioEstevao commented Nov 21, 2019

Added the missing Inspector Controls for video, except for the setting of the poster image that needs more custom work for native.

Simulator Screen Shot - iPhone 11 Pro Max - 2019-11-21 at 10 27 20

Gutenberg PR: WordPress/gutenberg#18660

To test:

  • Open the demo app
  • Tap on a video block
  • Tap on the settings icon (cog)
  • Check that the settings change the generated HTML

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@SergioEstevao SergioEstevao added this to the 1.18 milestone Nov 21, 2019
@SergioEstevao SergioEstevao requested a review from pinarol Nov 21, 2019
@SergioEstevao SergioEstevao changed the title Issue/implement video properties Implement video block settings Nov 21, 2019
@SergioEstevao SergioEstevao mentioned this pull request Nov 21, 2019
6 of 6 tasks complete
@SergioEstevao SergioEstevao requested a review from marecar3 Nov 22, 2019
@marecar3

This comment has been minimized.

Copy link
Contributor

marecar3 commented Nov 26, 2019

Hey @SergioEstevao, can we maybe link issue with this PR? Thanks.

Copy link
Contributor

marecar3 left a comment

LGTM!

@SergioEstevao SergioEstevao merged commit d39c152 into develop Nov 28, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@SergioEstevao SergioEstevao deleted the issue/implement_video_properties branch Nov 28, 2019
@cameronvoell cameronvoell modified the milestones: 1.18, 1.19 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.