Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Activate preformat block on android platform #1615
Result: There shouldn't be a red screen: wordpress-mobile/AztecEditor-Android#869 (comment)
Update release notes:
mchowning left a comment •
Also, I think we need to update the WPAndroid branch to reference the latest gutenberg and Aztec code.
1. Adding newline when last character on a line is a space causes problems with consecutive empty lines
2. Merging blocks with newlines loses newlines
This is probably caused by https://github.com/WordPress/gutenberg/blob/bb0529f59746e67dae47077bf91833e42a9081c5/packages/rich-text/src/component/index.native.js#L650. Aztec is trimming spaces in other cases but in the
I wasn't able to replicate that
Thanks a lot, @hypest, you opened my eyes, will let you know when I fix it.
Hey @hypest, I have fixed that issue.
hypest left a comment
Did a first pass reviewing Marko and left a couple of semi-minor comments. I want to do more testing of the writing flow before I LGTM this.
One of the issues I noticed, which also happens on the web is that if you have a PRE block with multiple empty lines in its end, merging another PRE seems to "eat up" the last empty line.
Steps to repro:
As I said, this happens on the web too so, no need to address it here.