Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list settings #1619

Merged
merged 21 commits into from Dec 9, 2019
Merged

Implement list settings #1619

merged 21 commits into from Dec 9, 2019

Conversation

@SergioEstevao
Copy link
Contributor

SergioEstevao commented Nov 26, 2019

Fixes #1304

Simulator Screen Shot - iPhone 11 Pro Max - 2019-11-26 at 12 08 18

To test:

  • Start the demo app
  • Add a new list block
  • Select the ordered list type
  • Add some lines to the list
  • Tap on the settings icon for the list
  • Change the properties start and reversed and see if the block updates correctly.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@SergioEstevao SergioEstevao added this to the 1.18 milestone Nov 26, 2019
@SergioEstevao SergioEstevao requested review from etoledom and marecar3 Nov 26, 2019
@SergioEstevao SergioEstevao mentioned this pull request Nov 26, 2019
6 of 6 tasks complete
@SergioEstevao SergioEstevao modified the milestones: 1.18, 1.19 Nov 26, 2019
Copy link
Contributor

etoledom left a comment

Hey @SergioEstevao - Thanks for taking care of this feature! 🎉

I found some weird behavior while testing it on iOS:

  • Changing settings won't always be reflected visually on the block
  • At some point the block format would break

There's a gif showing this issue:
list

It's interesting that some times the visual changes would work according to the settings. For example:

  • Create the ordered list with some elements.
  • Change settings to reversed (It won't show the changes visually in the list).
  • Go to HTML mode and back.
  • The block is re-rendered with the correct list order (reversed).
  • Select the block without making the keyboard active (tapping at the very edge).
  • Select the block settings and change properties.
    • It will refresh the block visually to reflect the changes
  • Select the block making the keyboard active and change some settings.
    • It won't refresh the block visually

One possible enhancement could be to show the numeric pad to set the Start Value setting.

I saw that TextControl has a type prop that is set to number on this setting, but it's not being handled properly in our native TextControl version. I think that if we pass the corresponding keyboardType to the Cell component it should work.


I gave it a pass on Android but I think it's not ready yet, right?

@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

SergioEstevao commented Nov 27, 2019

@etoledom Thanks for the great review! Two great catches, I updated the code to address those issues, can you please give it another look?

Copy link
Contributor

etoledom left a comment

Thank you @SergioEstevao for the update, it's working great now!

All the issues pointed out previously are now fixed 🎉

Not sure if we should wait for the Android implementation or we could have a platform check to ship on iOS ahead of time.

SergioEstevao and others added 3 commits Nov 28, 2019
@marecar3 marecar3 requested review from mchowning, hypest and maxme Nov 29, 2019
@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

SergioEstevao commented Nov 29, 2019

@marecar3 I tested the lists in Android and I see one bug, if you choose a reversed list without specifying a start value, the values are going from top value to 0. For example if you have 5 items we see:

4.
3.
2.
1.
0.

While the correct should be:

5.
4.
3.
2.
1.
marecar3 added 2 commits Dec 3, 2019
# Conflicts:
#	gutenberg
@marecar3

This comment has been minimized.

Copy link
Contributor

marecar3 commented Dec 3, 2019

@marecar3 I tested the lists in Android and I see one bug, if you choose a reversed list without specifying a start value, the values are going from top value to 0. For example if you have 5 items we see:

4.
3.
2.
1.
0.

While the correct should be:

5.
4.
3.
2.
1.

Hey @SergioEstevao, thanks for the feedback.
I have fixed the problem, please can you do another iteration of testing? Thanks.

@marecar3

This comment has been minimized.

Copy link
Contributor

marecar3 commented Dec 4, 2019

Hey @SergioEstevao, you can do another iteration of testing :) Thanks!

@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

SergioEstevao commented Dec 4, 2019

@marecar3 Working great now! Thanks for this! Do you need to merge anything in Aztec Android before I merge this?

SergioEstevao and others added 8 commits Dec 4, 2019
# Conflicts:
#	react-native-aztec/ios/Cartfile
#	react-native-aztec/ios/Cartfile.resolved
@SergioEstevao SergioEstevao merged commit f47c127 into develop Dec 9, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@SergioEstevao SergioEstevao deleted the issue/list_settings branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.