Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash dismissing bottom-sheet on iOS after device rotation #1628

Merged
merged 4 commits into from Nov 28, 2019

Conversation

@etoledom
Copy link
Contributor

etoledom commented Nov 27, 2019

Fixes #1522

This PR updates the gutenberg ref to test WordPress/gutenberg#18782

gutenberg side PR: WordPress/gutenberg#18782

To test:

  • Load the example content.
  • Find the Image block with image.
  • Press the image settings button.
  • Rotate the device.
  • Dismiss the settings sheet by pressing outside of it.
  • Check that it does not crash.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@etoledom etoledom added the bugfix label Nov 27, 2019
@etoledom etoledom added this to the 1.19 milestone Nov 27, 2019
@etoledom etoledom self-assigned this Nov 27, 2019
@etoledom etoledom marked this pull request as ready for review Nov 27, 2019
@etoledom etoledom requested a review from SergioEstevao Nov 27, 2019
Copy link
Contributor

SergioEstevao left a comment

Tested on iOS (phone and tablet) and Android and it's all working great!

:shipit:

@etoledom etoledom merged commit 509bf96 into develop Nov 28, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@etoledom etoledom deleted the issue/1522-fix-crash-rotating-bottom-sheet-ios branch Nov 28, 2019
@cameronvoell cameronvoell mentioned this pull request Dec 13, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.