Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/1592 fix alignment hiding image placeholder #1631

Merged
merged 2 commits into from Dec 17, 2019

Conversation

@mchowning
Copy link
Contributor

mchowning commented Nov 27, 2019

Fixes #1592

This fixes a bug that was introduced with the addition of paragraph alignment options. In particular, the placeholder icon would not display for an aligned image block if the image could not be downloaded.

Related gutenberg PR

To test:

  • Create a draft post on web with aligned images
  • Open an empty post in the app (to load the js from the metro bundler)
  • Go to the list of draft posts in the app so that the newly created draft is loaded
  • Turn on airplane mode
  • Open the draft post
  • Observe that all of the image blocks have visible placeholder images

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@mchowning mchowning added the bugfix label Nov 27, 2019
@mchowning mchowning added this to the 1.19 milestone Nov 27, 2019
@mchowning mchowning requested review from etoledom and cameronvoell Nov 27, 2019
@cameronvoell cameronvoell modified the milestones: 1.19, 1.20 Dec 16, 2019
Copy link
Contributor

etoledom left a comment

@@ -1,3 +1,7 @@
1.19.0
------
* Fix bug where image placeholders would sometimes not be shown

This comment has been minimized.

Copy link
@etoledom

etoledom Dec 17, 2019

Contributor

This should probably go to 1.20.0.

@mchowning mchowning force-pushed the issue/1592_fix_alignment_hiding_image_placeholder branch from a643eba to cca4d08 Dec 17, 2019
@mchowning mchowning mentioned this pull request Dec 17, 2019
6 of 6 tasks complete
@mchowning mchowning force-pushed the issue/1592_fix_alignment_hiding_image_placeholder branch from cca4d08 to 7df54fd Dec 17, 2019
@mchowning mchowning merged commit b3c48b0 into develop Dec 17, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@mchowning mchowning deleted the issue/1592_fix_alignment_hiding_image_placeholder branch Dec 17, 2019
@hypest hypest mentioned this pull request Dec 18, 2019
2 of 2 tasks complete
@designsimply

This comment has been minimized.

Copy link
Contributor

designsimply commented Jan 14, 2020

LGTM! (here is a screenshot from beta testing)

Screenshot_20200114-154305

Tested with WPAndroid 14.0-rc-1 on Pixel 3 Android 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.