Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block: Hide Size options when Image object is undefined #1669

Merged
merged 6 commits into from Dec 19, 2019

Conversation

@etoledom
Copy link
Contributor

etoledom commented Dec 10, 2019

This PR fixes point 3 of #1593

gutenberg side PR: WordPress/gutenberg#19037

When the image object is not present, the Image Size option won't be present in the Image Options.

The Image object is fetched on a network call for images stored in the WP Media Library. For images added via link, this object is never fetched.

Other cause of the object being missing is network call errors.

With this change we are looking to avoid the case when the ImageSize is displayed in the UI, but it does nothing.

Test:

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
@etoledom etoledom added this to the 1.20 milestone Dec 10, 2019
@etoledom etoledom requested a review from mchowning Dec 10, 2019
@etoledom etoledom self-assigned this Dec 10, 2019
@etoledom etoledom changed the title Update gutenberg ref Image block: Hide Size options when Image object is undefined Dec 10, 2019
@etoledom etoledom mentioned this pull request Dec 16, 2019
4 of 7 tasks complete
@etoledom etoledom force-pushed the issue/hide-image-size-option-conditionally branch from 54b8fe2 to d845357 Dec 18, 2019
@etoledom etoledom merged commit 7b559b9 into develop Dec 19, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@etoledom etoledom deleted the issue/hide-image-size-option-conditionally branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.