Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crash after block removal due to `undo` button pressing #1701

Merged
merged 13 commits into from Dec 26, 2019

Conversation

@lukewalczak
Copy link
Collaborator

lukewalczak commented Dec 19, 2019

Fixes #1699 & wordpress-mobile/WordPress-Android#10876

Ref to gutenberg repo: WordPress/gutenberg#19239
To test:

1.Open mobile app
2. Add a block
3.Press undo button
4. Add a new block - if app not crashing everything is good 馃憤

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@lukewalczak lukewalczak self-assigned this Dec 19, 2019
@lukewalczak lukewalczak mentioned this pull request Dec 19, 2019
6 of 6 tasks complete
@geriux geriux self-requested a review Dec 19, 2019
@lukewalczak lukewalczak added the bugfix label Dec 19, 2019
@geriux
geriux approved these changes Dec 19, 2019
Copy link
Member

geriux left a comment

Looks good! Tested it via WordPress/gutenberg#19239 (review)

Can you please reference the other issue in this PR as well? So we can keep track of it after we release this.

lukewalczak and others added 11 commits Dec 19, 2019
@geriux geriux merged commit 86ceb4e into develop Dec 26, 2019
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@geriux geriux deleted the fix-undo-crash branch Dec 26, 2019
@Tug Tug added this to the 1.20 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.