Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing DEV flag for Image block size options #1904

Merged
merged 3 commits into from Feb 14, 2020

Conversation

@cameronvoell
Copy link
Contributor

cameronvoell commented Feb 14, 2020

Fixes #1329

Description

We recently finished resolving behavioral issues related to updating images sizes on mobile, and are therefore removing the DEV flag blocking the feature in non-development builds.
See - #1593

Related PRs:

Screenshot

size-changes

To test

(Changes tested in individual PRs from #1593):
(Must be tested in WP Apps, see test PRs above)

  1. Add an Image Block and upload an image
  2. Click the gear for block settings
  3. Tap Image Size row and verify value cycles through available sizes (Thumbnail, Medium, Large, Fullscreen).
  4. Verify the Image size changes as you click through the menu.
  5. Verify the Image Size is preserved if you update the post, leave, and return.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
@etoledom

This comment has been minimized.

Copy link
Contributor

etoledom commented Feb 14, 2020

Thank you @cameronvoell for this!
Changes look good, but I'm investigating the failing tests on wordpress-mobile/WordPress-iOS#13462

It doesn't seem to be related to this particular PR, but I'd be more confident to merge after this is figured out.

Copy link
Contributor

etoledom left a comment

So, the UI Tests failure on WPiOS will be fixed separately and has no relation with this PR.

Lets :shipit: ! 🎉
Thank you @cameronvoell 🙏

Let's also revert the bundles before merging this PR.

@cameronvoell cameronvoell force-pushed the add/image-size-options-without-dev-flag branch from 816a759 to 16b0bd1 Feb 14, 2020
@cameronvoell

This comment has been minimized.

Copy link
Contributor Author

cameronvoell commented Feb 14, 2020

Bundle update reverted, and gutenberg reference updated., merging!

@cameronvoell cameronvoell merged commit 6ec05f0 into develop Feb 14, 2020
5 checks passed
5 checks passed
ci/circleci: Check Correctness Your tests passed on CircleCI!
Details
ci/circleci: Test Android Your tests passed on CircleCI!
Details
ci/circleci: Test Android on Device Your tests passed on CircleCI!
Details
ci/circleci: Test iOS Your tests passed on CircleCI!
Details
ci/circleci: Test iOS on Device Your tests passed on CircleCI!
Details
@etoledom etoledom deleted the add/image-size-options-without-dev-flag branch Feb 24, 2020
@etoledom etoledom mentioned this pull request Feb 24, 2020
8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.