Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UBE's Inaccessible "More" Toolbar Item on Android #3771

Merged
merged 7 commits into from Aug 2, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jul 29, 2021

Fixes WordPress/gutenberg#33592

gutenberg: WordPress/gutenberg#33740

Description

The "more" toolbar item isn't currently accessible from the Unsupported Block Editor (UBE) within the Android app. As outlined in WordPress/gutenberg#33592, tapping on the toolbar items results in a flash of a dropdown menu, but that menu instantly disappears. This PR includes a fix for that.

Testing

To test and for more details, please refer to the Gutenberg PR here: WordPress/gutenberg#33740


PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 29, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB marked this pull request as ready for review July 29, 2021 18:14
@SiobhyB SiobhyB requested a review from enejb July 29, 2021 18:15
Copy link
Contributor

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the APK file and it worked as expected for me!
Nice work!

@SiobhyB SiobhyB enabled auto-merge August 2, 2021 18:23
@SiobhyB SiobhyB merged commit 0db6285 into develop Aug 2, 2021
@SiobhyB SiobhyB deleted the fix/ube-more-button-android branch August 2, 2021 18:42
@dcalhoun dcalhoun mentioned this pull request Aug 6, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Android: "More" Toolbar Item Isn't Accessible from Unsupported Block Editor
2 participants