Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested block / inner block to tutorial #17559

Merged
merged 6 commits into from Jan 2, 2020
Merged

Add nested block / inner block to tutorial #17559

merged 6 commits into from Jan 2, 2020

Conversation

@mkaz
Copy link
Member

mkaz commented Sep 24, 2019

Description

Adds a new page to the block tutorial for Nested Blocks using InnerBlocks.

How has this been tested?

Follow documentation and confirm it works. View live on branch here.

Types of changes

Documentation.

mkaz added 4 commits Sep 24, 2019
Adds an exmaple using InnerBlocks to the block tutorial
@mkaz mkaz force-pushed the docs/add-nested-block branch from 70cc70a to b9b7e0c Oct 9, 2019
@gziolo gziolo requested a review from jorgefilipecosta Oct 10, 2019
@@ -86,7 +86,9 @@
{ "docs/designers-developers/developers/tutorials/block-tutorial/introducing-attributes-and-editable-fields.md": [] },
{ "docs/designers-developers/developers/tutorials/block-tutorial/block-controls-toolbar-and-sidebar.md": [] },
{ "docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md": [] },
{ "docs/designers-developers/developers/tutorials/block-tutorial/generate-blocks-with-wp-cli.md": [] }
{ "docs/designers-developers/developers/tutorials/block-tutorial/generate-blocks-with-wp-cli.md": [] },

This comment has been minimized.

Copy link
@nosolosw

nosolosw Oct 11, 2019

Member

How about shifting the order and having the inner blocks tutorial first? The steps of the block tutorial look clearer that way (build more complex things as you advanced) and the rhythm doesn't get broken by the CLI tutorial (which isn't about things you could use to build blocks but block set up instead).

This comment has been minimized.

Copy link
@gziolo

gziolo Oct 11, 2019

Member

I'm wondering if this CLI tutorial is still up to date 🤔

This comment has been minimized.

Copy link
@mkaz

mkaz Oct 11, 2019

Author Member

Yeh, I kinda want to remove the CLI suggestion. I was going to post about that in a separate PR. I'm not sure if the scaffolding that it generates is really what we want.

This comment has been minimized.

Copy link
@nosolosw

nosolosw Jan 2, 2020

Member

It may be worth revisiting the CLI part, even to delete it. In the meantime, I think that section fits better after the nested/inner blocks tutorial.

@nosolosw

This comment has been minimized.

Copy link
Member

nosolosw commented Oct 11, 2019

I've gone too tactical perhaps in that I've commented on little things here and there. My bigger question is: do we require this new addition to the block tutorial to be a full working example with the corresponding code in gutenberg-examples repo? The other parts of the tutorial do have that, so I guess we should follow that pattern. If we feel that we can do differently, I'm open to other approaches.

Thanks for the improvements!

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
@mkaz

This comment has been minimized.

Copy link
Member Author

mkaz commented Oct 11, 2019

@nosolosw yes, I think we should add it to gutenberg-examples repo, but that should not be necessary for merge, it is better to get some documentation up than none.

The gutenberg-examples repo being numbered makes it tricky to add items to it. Since I think this one could fit in-between other lessons. I also don't like the disconnect between the explanation in the tutorial and the examples repo, but not quite sure how to solve.

So I've been mulling over how we could adopt and change that repo, but haven't really come up with something concrete enough to propose.

Copy link
Member

nosolosw left a comment

I've left a couple of comments; otherwise, this can be merged.

@nosolosw nosolosw mentioned this pull request Jan 2, 2020
@nosolosw

This comment has been minimized.

Copy link
Member

nosolosw commented Jan 2, 2020

I've created WordPress/gutenberg-examples#102 to port this example to gutenberg-examples.

Co-Authored-By: Andrés <nosolosw@users.noreply.github.com>
@mkaz mkaz merged commit 772a5d5 into master Jan 2, 2020
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the docs/add-nested-block branch Jan 2, 2020
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.