Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update columns index.js adding translatable (i18n) parts #18162

Merged
merged 2 commits into from Dec 17, 2019

Conversation

@nukaga
Copy link
Contributor

nukaga commented Oct 29, 2019

Adding translatable (i18n) parts

Description

Part of the series of sentences displayed in "lorem ipsum" was not translatable.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Adding translatable (i18n) parts
Copy link
Member

jorgefilipecosta left a comment

Hi @nukaga thank you for your contribution 👍
These strings are example text and not supposed to be readable, but I guess in some languages with different charsets this example text may not look good, so making them translatable seems like a solution. Any thoughts on this @swissspidy?

@swissspidy

This comment has been minimized.

Copy link
Member

swissspidy commented Oct 31, 2019

I guess in some languages with different charsets this example text may not look good

Just think about Arabic or Japanese and how lorem ipsum does not work for these languages.

@swissspidy

This comment has been minimized.

Copy link
Member

swissspidy commented Oct 31, 2019

Ideally we'd also add some translator comment that mentions that this is example text.

@torounit

This comment has been minimized.

Copy link
Contributor

torounit commented Nov 6, 2019

Should use _x instead of __ ?

Copy link
Member

jorgefilipecosta left a comment

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 8b4922e into WordPress:master Dec 17, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta

This comment has been minimized.

Copy link
Member

jorgefilipecosta commented Dec 17, 2019

Should use _x instead of __ ?

Hi @torounit, _x should be used when the same word/string can have different translations depending on the context it is used. It seems this example strings don't fit that use case, so I think we can use __.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.