Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keyword 'download' to the file block for easier searching. #18995

Merged
merged 3 commits into from Dec 9, 2019

Conversation

@mapk
Copy link
Contributor

mapk commented Dec 7, 2019

Description

Added a new keyword to the File block for easier searching: download.

How has this been tested?

Tested locally.

Screenshots

Screen Shot 2019-12-07 at 10 04 01 AM

Types of changes

Non-breaking changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@melchoyce

This comment has been minimized.

Copy link
Contributor

melchoyce commented Dec 7, 2019

Is it okay that package-lock.json changed too?

@aduth

This comment has been minimized.

Copy link
Member

aduth commented Dec 8, 2019

Is it okay that package-lock.json changed too?

It doesn't seem to me that it should be expected to be updated here.

@karmatosed

This comment has been minimized.

Copy link
Member

karmatosed commented Dec 9, 2019

Yes, the .json file isn't needed and likely came from doing an npm install audit fix, or something localhost side. @mapk can you push a PR without that file, please?

@mapk

This comment has been minimized.

Copy link
Contributor Author

mapk commented Dec 9, 2019

Oh danggit, @melchoyce. I think you're right. Let me see if I can fix that.

@aduth
aduth approved these changes Dec 9, 2019
@mapk

This comment has been minimized.

Copy link
Contributor Author

mapk commented Dec 9, 2019

Thanks, @aduth for figuring out how to reset the package-lock.json file again. I appreciate the insight! 👍

@mapk mapk merged commit 2f64cb5 into master Dec 9, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mapk mapk deleted the add/file-block-keyword branch Dec 9, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.