Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import WritingFlow and ObserveTyping #19005

Merged

Conversation

@WebPraktikos
Copy link
Contributor

WebPraktikos commented Dec 8, 2019

Description

Inside the block-editor “Usage” readme instructions, modules WritingFlow and ObserveTyping are used but not imported

Types of changes

Bug fix (non-breaking change which fixes an issue)

Copy link
Member

aduth left a comment

Thanks for this improvement! While you're making these changes, could you also include the necessary import for Popover ? It should be imported from @wordpress/components.

@WebPraktikos WebPraktikos force-pushed the WebPraktikos:fix/block-editor-instructions branch from 52af5b4 to db9f0d2 Dec 9, 2019
@WebPraktikos WebPraktikos force-pushed the WebPraktikos:fix/block-editor-instructions branch from db9f0d2 to ea9a84d Dec 9, 2019
@WebPraktikos

This comment has been minimized.

Copy link
Contributor Author

WebPraktikos commented Dec 9, 2019

Oh, we keep missing it :D Now it includes Popover.

Copy link
Contributor

youknowriad left a comment

LGTM 👍

@youknowriad youknowriad merged commit 6eb2029 into WordPress:master Dec 9, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.