Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to hooks useViewportMatch and useMediaQuery #19019

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Dec 9, 2019

Description

This PR just adds unit tests to useViewportMatch and useMediaQuery.
Unit tests will be useful for example to test the new simulation mechanism we are working on for useViewportMatch.

How has this been tested?

I verified the unit tests pass using run test-unit.

Copy link
Contributor

youknowriad left a comment

nice

@jorgefilipecosta jorgefilipecosta force-pushed the add/unit-tests-to-hooks-useViewportMatch-and-useMediaQuery branch from f5719ab to 8b7a51d Dec 10, 2019
@jorgefilipecosta jorgefilipecosta merged commit ed66431 into master Dec 10, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Failed
Details
@jorgefilipecosta jorgefilipecosta deleted the add/unit-tests-to-hooks-useViewportMatch-and-useMediaQuery branch Dec 10, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.