Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Add readme for `CustomSelectControl`. #19026

Merged
merged 1 commit into from Dec 29, 2019

Conversation

@epiqueras
Copy link
Contributor

epiqueras commented Dec 9, 2019

Why do we have a docs/manifest-devhub.json and an incomplete docs/manifest.json?

@chrisvanpatten

This comment has been minimized.

Copy link
Member

chrisvanpatten commented Dec 10, 2019

@epiqueras #15639 ← have been swamped with work for a bit, but basically this PR needs to be finished. will see if I can rebase this week and get it done, unless you want to take it across the finish line

@epiqueras

This comment has been minimized.

Copy link
Contributor Author

epiqueras commented Dec 10, 2019

@karmatosed karmatosed added this to Design feedback in Tightening Up Dec 11, 2019
@karmatosed karmatosed moved this from Design feedback to In Progress in Tightening Up Dec 11, 2019
@mkaz
mkaz approved these changes Dec 29, 2019
Copy link
Member

mkaz left a comment

The readme.md looks good 👍
We can address the manifest-devhub issue in the #15639

@mkaz mkaz merged commit 8084e23 into master Dec 29, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the add/custom-select-control-readme branch Dec 29, 2019
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.2 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.