Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drag & Drop does not work on the widgets screen #19029

Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Dec 10, 2019

Description

Currently, Drag & Drop does not work on the widgets screen. That happens not only because DropZoneProvider was not being. Adding DropZoneProvider does not immediately fix the problem and it was not easy to find the cause. I started debugging the Drag & Drop mechanism but the problem was not there. The problem was that the drop-zone appender took all the widgets to screen so when dragging & dropping a block the triggered area was not the blocks but the appender(which did nothing). This PR fixes that problem with a simple CSS rule that does not changes the visual.

How has this been tested?

I verified I could use drag & drop on the widgets screen.

@jorgefilipecosta jorgefilipecosta requested a review from youknowriad as a code owner Dec 10, 2019
@jorgefilipecosta jorgefilipecosta merged commit acd5477 into master Dec 10, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/drag-drop-does-not-work-on-the-widgets-screen branch Dec 10, 2019
@@ -21,25 +22,27 @@ function Layout( { blockEditorSettings } ) {
const [ selectedArea, setSelectedArea ] = useState( null );
return (
<SlotFillProvider>

This comment has been minimized.

Copy link
@youknowriad

youknowriad Dec 10, 2019

Contributor

This screen could reuse the EditorRegions component (if we find a way to expose it properly) and avoid duplicate a lot of CSS.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.