Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: Validate embed rendering before proceeding to next #19042

Merged
merged 1 commit into from Dec 10, 2019

Conversation

@aduth
Copy link
Member

aduth commented Dec 10, 2019

Fixes #19033

This pull request seeks to improve stability of the embedding end-to-end test suite. See #19033 for complete debugging details.

The changes here operate on the assumption that there is a race condition between embed resizing and the behavior of Puppeteer's page.click to bring the block appender into view between adding embeds.

The goal of these changes is to change from:

Before: Add all blocks, then validate the results.
After: Validate the result of an embed insertion before proceeding to add the next.

The idea with this is that, by performing the validation using waitForSelector, we can have a higher confidence that the embed preview is rendered in its final state, and won't be subject to further resizing.

Testing Instructions:

Build should pass.

Ensure end-to-end tests pass:

npm run test-e2e packages/e2e-tests/specs/editor/various/embedding.test.js
@aduth aduth merged commit d525f86 into master Dec 10, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the update/e2e-embeds-wait-validate branch Dec 10, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.