Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Block Editor: Remove legacy "editor-" class name compatibility #19050
This pull request seeks to remove the
This brings with it a few benefits:
My process was as follows:
To find the legacy classes, I performed a regular expression search on the files of the
Once all the changes had been made, I compiled a complete set of folders where files had been modified, to use as the "Base" of our BEM naming convention to perform a search on the entire repository for lingering references to the legacy class names:
This yielded many results where one of the following holds true:
Repeat testing instructions from #14420.
When they were introduced, it was the expectation that existing code would continue to work without any revisions, so a devnote wasn't deemed as being necessary. Since there could be revisions necessary as a result of this pull request, I've flagged it "Needs Dev Note" based on guidance from the backward compatibility document.
Aha! I must have forgotten about this, but you're correct:
I've noticed that a lot of the default themes still reference many of the old class names.
@mapk Do you have any suggestions on how we'd want to address this? I could open a Trac ticket for the themes to be updated. I'm not sure how that works with respect to if and how theme updates apply for older versions of WordPress (i.e. since these
I think this might explain some of the visual oddities I've been observing when using recent versions of Gutenberg with default themes.
At worst, it's something where we could revert the changes (and in #19489) until we figure out a better solution. But this puts us at odds with our own guidelines and kicks the can further down the road.