Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: don't set selection in componentDidUpdate during pending store update #19055

merged 1 commit into from Dec 11, 2019


Copy link

ellatrix commented Dec 11, 2019


Tries to fix #18362. The problem is that the selection is not correctly set after merging back.
This will probably have failing e2e tests.

How has this been tested?


Types of changes


  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@ellatrix ellatrix force-pushed the try/18362 branch from 44e39d7 to 4999ff3 Dec 11, 2019
@ellatrix ellatrix requested review from ajitbohra, nerrad, ntwb and talldan as code owners Dec 11, 2019
@ellatrix ellatrix changed the title WIP RichText: don't set selection in componentDidUpdate during pending store update Dec 11, 2019
@ellatrix ellatrix merged commit 166f4c6 into master Dec 11, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
@ellatrix ellatrix deleted the try/18362 branch Dec 11, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.