Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Shallow Equal: Add types #19090

Merged
merged 1 commit into from Dec 12, 2019
Merged

Is Shallow Equal: Add types #19090

merged 1 commit into from Dec 12, 2019

Conversation

@sirreal
Copy link
Member

sirreal commented Dec 12, 2019

Description

Part of #18838
Extracted from #18942

Add types to is-shallow-equal package.

Testing Instructions:

Verify type checking passes:

npm run lint-types
@sirreal sirreal marked this pull request as ready for review Dec 12, 2019
@sirreal sirreal requested a review from aduth as a code owner Dec 12, 2019
@aduth aduth mentioned this pull request Dec 12, 2019
9 of 67 tasks complete
@aduth
aduth approved these changes Dec 12, 2019
Copy link
Member

aduth left a comment

Can you rebase?

@sirreal sirreal force-pushed the add/types-is-shallow-equal branch from 4fc92b0 to 791599b Dec 12, 2019
@sirreal

This comment has been minimized.

Copy link
Member Author

sirreal commented Dec 12, 2019

Rebased.

@sirreal sirreal merged commit cbbf1fe into master Dec 12, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@sirreal sirreal deleted the add/types-is-shallow-equal branch Dec 12, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.