Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor the MediaReplaceFlow component to use Dropdown #19126
Hi @youknowriad great PR, I tested this and it works nicely! I think this approach is better, can't say exactly why I settled on Popover but the flow has been through many iterations and (as you mentioned) some things required some refactoring of the core components at some stages of these iterations.
In this stage a dropdown (not a dropdown-menu sinch this is more than a menu) is the perfect choice.
There is a small difference in the roundness of the edit URL input:
In master the URL looks like this:
I am unsure if this is a problem.