Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a narrow trash button #19131

Merged
merged 1 commit into from Dec 13, 2019
Merged

Try a narrow trash button #19131

merged 1 commit into from Dec 13, 2019

Conversation

@karmatosed
Copy link
Member

karmatosed commented Dec 13, 2019

The trash button right now is full width, which is not a pattern used a lot elsewhere. It also encourages you to move to trash almost as so large.

3

A little fix to this could be to explore just making it a normal button here:

2

I would argue making it just a text link could also work, but let's see what feedback is about the button for now.

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

ZebulanStanphill commented Dec 13, 2019

Makes sense to me. 👍

@shaunandrews

This comment has been minimized.

Copy link

shaunandrews commented Dec 13, 2019

The smaller button looks a little strange, visually, but I agree the wide button is way too prominent. I'd be in favor of trying a link style for this — but happy to have that be a separate PR. Along with that, it'd be really nice to add a confirmation to this action.

@karmatosed

This comment has been minimized.

Copy link
Member Author

karmatosed commented Dec 13, 2019

Ok based on feelings, let's try a smaller button then we can try a PR for a link if people think it's too weird. I would also be happy to try a link. Thanks, everyone.

@karmatosed karmatosed merged commit 1a9094b into master Dec 13, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@karmatosed karmatosed deleted the try/trash-narrow branch Dec 13, 2019
@MichaelArestad

This comment has been minimized.

Copy link

MichaelArestad commented Dec 16, 2019

I'd second revisiting as a link. It's not a primary or even secondary action. I don't see a need to draw more attention to it than necessary and a link feels about right in the visual hierarchy.

@karmatosed

This comment has been minimized.

Copy link
Member Author

karmatosed commented Dec 16, 2019

@MichaelArestad it's now merged as a link #19138

@MichaelArestad

This comment has been minimized.

Copy link

MichaelArestad commented Dec 16, 2019

Oh heck yes!

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.