Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package changelog with note about dependency file name changing #19146

Merged
merged 2 commits into from Dec 14, 2019

Conversation

@chrisvanpatten
Copy link
Member

chrisvanpatten commented Dec 14, 2019

Description

This PR adds a small note to the Dependency Extraction Webpack Plugin changelog to note that in addition to the default file format and file shape changing, the filename also changed.

This was discussed in the #core-js WordPress Slack channel (registration required).

How has this been tested?

No tests; documentation-only change.

Screenshots

n/a

Types of changes

Documentation change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@chrisvanpatten chrisvanpatten requested review from gziolo and aduth Dec 14, 2019
@chrisvanpatten chrisvanpatten self-assigned this Dec 14, 2019
@chrisvanpatten chrisvanpatten changed the title Update changelog with note about dependency file name changing Update package changelog with note about dependency file name changing Dec 14, 2019
@gziolo
gziolo approved these changes Dec 14, 2019
Copy link
Member

gziolo left a comment

Thanks for adding this clarification 👍

@chrisvanpatten chrisvanpatten merged commit bfd1117 into master Dec 14, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@chrisvanpatten chrisvanpatten deleted the add/asset-file-name-change-bc-note branch Dec 14, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.