Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Custom select control - using items width instead of 100% #19130 #19150

Conversation

@devdivdev
Copy link
Contributor

devdivdev commented Dec 15, 2019

Description

Fixing #19130

How has this been tested?

Screenshots

After the change
https://imgur.com/w1BFGkb

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
Copy link
Contributor

epiqueras left a comment

Thanks for working on this!

How about we change width to min-width instead of deleting it. That way if all the options are small, the menu still has the same width as the toggle and doesn't look strange, but it can still grow to accommodate bigger items like "Huge".

@devdivdev

This comment has been minimized.

Copy link
Contributor Author

devdivdev commented Dec 15, 2019

Thanks @epiqueras for the feedback, yes using a min-width is definitely a better approache :)

@devdivdev devdivdev marked this pull request as ready for review Dec 15, 2019
@youknowriad youknowriad merged commit 3050360 into WordPress:master Dec 24, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.