Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Test ContrastChecker notices by string comparison #19169

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@aduth
Copy link
Member

aduth commented Dec 16, 2019

This pull request seeks to update ContrastChecker component unit tests to use direct string comparison assertions in place of the existing snapshot tests. As noted at #14995 (comment), the use of snapshot tests here is too unreliable, given that the tinycolor2 dependency uses an internal global increment which can change unexpectedly, requiring updates to the snapshot tests.

Testing Instructions:

Tests should still pass:

npm run test-unit packages/block-editor/src/components/contrast-checker/test/index.js
Copy link
Contributor

youknowriad left a comment

Nice ⭐️

@aduth aduth merged commit 74269e6 into master Dec 16, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the remove/contrast-checker-snapshots branch Dec 16, 2019
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.